linux-ext4 - Re: [PATCH 1/2] ext2: convert to the new mount API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <icjrsdd2irambcw4woz7p7m2ebwonpr6dqwzczyalz5d2iwmie@wn25mu252mcr>
Date: Wed, 26 Feb 2025 18:03:53 +0100
From: Jan Kara <jack@...e.cz>
To: Eric Sandeen <sandeen@...deen.net>
Cc: Jan Kara <jack@...e.cz>, Eric Sandeen <sandeen@...hat.com>, 
	jack@...e.com, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/2] ext2: convert to the new mount API

On Wed 26-02-25 10:42:11, Eric Sandeen wrote:
> On 2/24/25 8:02 AM, Jan Kara wrote:
> > On Sun 23-02-25 13:57:40, Eric Sandeen wrote:
> >> Convert ext2 to the new mount API.
> >>
> >> Note that this makes the sb= option more accepting than it was before;
> >> previosly, sb= was only accepted if it was the first specified option.
> >> Now it can exist anywhere, and if respecified, the last specified value
> >> is used.
> >>
> >> Parse-time messages here are sent to ext2_msg with a NULL sb, and
> >> ext2_msg is adjusted to accept that, as ext4 does today as well.
> >>
> >> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
> > 
> > Looks good to me. Thanks!
> 
> Thanks Jan - You probably saw the minor nit from the kernel test robot,
> "const struct fs_parameter_spec ext2_param_spec" should be static, too.

Yep, fixed now.

> Sorry about that! 

No problem :).

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR