linux-ext4 - Re: [PATCH] ext4: remove unnecessary checks for __GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9be439b3-fd43-4a4b-96e5-0d0ec5fb1509@huawei.com>
Date: Fri, 28 Feb 2025 16:44:42 +0800
From: Baokun Li <libaokun1@...wei.com>
To: Julian Sun <sunjunchao2870@...il.com>, <linux-ext4@...r.kernel.org>
CC: <tytso@....edu>, <adilger.kernel@...ger.ca>, <jack@...e.cz>, Yang Erkun
	<yangerkun@...wei.com>
Subject: Re: [PATCH] ext4: remove unnecessary checks for __GFP_NOFAIL
 allocation.

On 2025/2/28 16:11, Julian Sun wrote:
> The __GFP_NOFAIL flag ensures that allocation will not fail.
> So remove the unnecessary checks.
Actually, even with __GFP_NOFAIL set, kcalloc() can still return NULL,
such as when the input parameters overflow.


Baokun
>
> Signed-off-by: Julian Sun <sunjunchao2870@...il.com>
> ---
>   fs/ext4/extents.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index a07a98a4b97a..95debd5d6506 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -2940,10 +2940,6 @@ int ext4_ext_remove_space(struct inode *inode, ext4_lblk_t start,
>   	} else {
>   		path = kcalloc(depth + 1, sizeof(struct ext4_ext_path),
>   			       GFP_NOFS | __GFP_NOFAIL);
> -		if (path == NULL) {
> -			ext4_journal_stop(handle);
> -			return -ENOMEM;
> -		}
>   		path[0].p_maxdepth = path[0].p_depth = depth;
>   		path[0].p_hdr = ext_inode_hdr(inode);
>   		i = 0;