linux-ext4 - Re: [PATCH v4 3/6] check: Remove redundant _test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250409152146.GN6283@frogsfrogsfrogs>
Date: Wed, 9 Apr 2025 08:21:46 -0700
From: "Darrick J. Wong" <djwong@...nel.org>
To: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@...il.com>
Cc: fstests@...r.kernel.org, linux-ext4@...r.kernel.org,
	linux-xfs@...r.kernel.org, ritesh.list@...il.com,
	ojaswin@...ux.ibm.com, zlang@...nel.org, david@...morbit.com
Subject: Re: [PATCH v4 3/6] check: Remove redundant _test_mount in check

On Wed, Apr 09, 2025 at 07:00:49AM +0000, Nirjhar Roy (IBM) wrote:
> init_rc already does a _test_mount. Hence removing the additional
> _test_mount call when OLD_TEST_FS_MOUNT_OPTS != TEST_FS_MOUNT_OPTS.
> 
> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@...il.com>
> Reviewed-by: Dave Chinner <dchinner@...hat.com>
> Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@...il.com>
> ---
>  check | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/check b/check
> index 32890470..3d621210 100755
> --- a/check
> +++ b/check
> @@ -791,13 +791,9 @@ function run_section()
>  		. common/rc
>  		_prepare_test_list
>  	elif [ "$OLD_TEST_FS_MOUNT_OPTS" != "$TEST_FS_MOUNT_OPTS" ]; then
> +		# Unmount TEST_DEV to apply the updated mount options.
> +		# It will be mounted again by init_rc(), called shortly after.

Thanks for adding this comment!  Future me will probably appreciate this
breadcrumb. :)
Reviewed-by: "Darrick J. Wong" <djwong@...nel.org>

--D

>  		_test_unmount 2> /dev/null
> -		if ! _test_mount
> -		then
> -			echo "check: failed to mount $TEST_DEV on $TEST_DIR"
> -			status=1
> -			exit
> -		fi
>  	fi
>  
>  	init_rc
> -- 
> 2.34.1
> 
>