linux-ext4 - Re: [PATCH v2 6/8] fs/ext4: use sleeping version of __find_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250410173236.jk5cksfw5zege5n7@offworld>
Date: Thu, 10 Apr 2025 10:32:36 -0700
From: Davidlohr Bueso <dave@...olabs.net>
To: Jan Kara <jack@...e.cz>
Cc: Luis Chamberlain <mcgrof@...nel.org>, brauner@...nel.org, tytso@....edu,
	adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org,
	riel@...riel.com, willy@...radead.org, hannes@...xchg.org,
	oliver.sang@...el.com, david@...hat.com, axboe@...nel.dk,
	hare@...e.de, david@...morbit.com, djwong@...nel.org,
	ritesh.list@...il.com, linux-fsdevel@...r.kernel.org,
	linux-block@...r.kernel.org, linux-mm@...ck.org,
	gost.dev@...sung.com, p.raghav@...sung.com, da.gomez@...sung.com
Subject: Re: [PATCH v2 6/8] fs/ext4: use sleeping version of
 __find_get_block()

On Thu, 10 Apr 2025, Jan Kara wrote:

>> @@ -860,6 +860,8 @@ struct buffer_head *ext4_getblk(handle_t *handle, struct inode *inode,
>>		return sb_find_get_block(inode->i_sb, map.m_pblk);
>>
>>	/*
>> +	 * Potential TODO: use sb_find_get_block_nonatomic() instead.
>> +	 *
>
>Yes, please. Since we are behind nowait check, we are fine with blocking...

Yes, I will send a follow up that replaces that getblk_unmovable() with
sb_find_get_block_nonatomic().