linux-ext4 - Re: [PATCH 4/7] fs/ocfs2: use sleeping version of __find_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eaibtk55ct3nwuvta3yoe3mkzywp4dyehswxpjqjnivue5s57t@honop3yup4y3>
Date: Wed, 16 Apr 2025 11:35:45 +0200
From: Jan Kara <jack@...e.cz>
To: Davidlohr Bueso <dave@...olabs.net>
Cc: jack@...e.cz, tytso@....edu, adilger.kernel@...ger.ca, 
	brauner@...nel.org, mcgrof@...nel.org, willy@...radead.org, hare@...e.de, 
	djwong@...nel.org, linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, 
	linux-mm@...ck.org
Subject: Re: [PATCH 4/7] fs/ocfs2: use sleeping version of __find_get_block()

On Tue 15-04-25 16:16:32, Davidlohr Bueso wrote:
> This is a path that allows for blocking as it does IO. Convert
> to the new nonatomic flavor to benefit from potential performance
> benefits and adapt in the future vs migration such that semantics
> are kept.
> 
> Suggested-by: Jan Kara <jack@...e.cz>
> Signed-off-by: Davidlohr Bueso <dave@...olabs.net>

One nit below but either way feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

> diff --git a/fs/ocfs2/journal.c b/fs/ocfs2/journal.c
> index f1b4b3e611cb..c7a9729dc9d0 100644
> --- a/fs/ocfs2/journal.c
> +++ b/fs/ocfs2/journal.c
> @@ -1249,7 +1249,7 @@ static int ocfs2_force_read_journal(struct inode *inode)
>  		}
>  
>  		for (i = 0; i < p_blocks; i++, p_blkno++) {
> -			bh = __find_get_block(osb->sb->s_bdev, p_blkno,
> +			bh = __find_get_block_nonatomic(osb->sb->s_bdev, p_blkno,

This could be using sb_find_get_block_nonatomic().

>  					osb->sb->s_blocksize);
>  			/* block not cached. */
>  			if (!bh)
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR