linux-ext4 - Re: [PATCH v8 0/9] Ext4 Fast Commit Performance Patchset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD+ocbzqihJidUkanZLwUfHFNyEs0SO_Tbx4ABr_9W3dRVbArg@mail.gmail.com>
Date: Wed, 30 Apr 2025 11:55:48 -0700
From: harshad shirwadkar <harshadshirwadkar@...il.com>
To: "Theodore Ts'o" <tytso@....edu>
Cc: linux-ext4@...r.kernel.org, jack@...e.cz, harshads@...gle.com
Subject: Re: [PATCH v8 0/9] Ext4 Fast Commit Performance Patchset

Hi Ted,

I tried to run this on my end, and I didn't see the errors that you
pointed out. Here's my run:

Failures: ext4/049 generic/459 generic/506 generic/645
Failed 4 of 553 tests
Xunit report: /results/ext4/results-fast_commit/result.xml

END TEST: Ext4 4k block w/fast_commit Wed Apr 30 18:15:26 UTC 2025
-------------------- Summary report
KERNEL:    kernel 6.14.0-rc2-xfstests-perf-gff9ebf4dde0d #31 SMP
PREEMPT_DYNAMIC Sat Apr 12 19:35:39 UTC 2025 x86_64
CMDLINE:   -c fast_commit -g auto

I explicitly also ran the tests were causing error for you and I still
don't see any failures:

Ran: generic/127 generic/241 generic/418
Passed all 3 tests
Xunit report: /results/ext4/results-fast_commit/result.xml
-------------------- Summary report
KERNEL:    kernel 6.14.0-rc2-xfstests-perf-gff9ebf4dde0d #31 SMP
PREEMPT_DYNAMIC Sat Apr 12 19:35:39 UTC 2025 x86_64
CMDLINE:   -c fast_commit generic/127 generic/241 generic/418

Maybe my patches are conflicting with some other patches that are
being merged? Let's talk about this in tomorrow's call.

Thank you,
Harshad

On Fri, Apr 25, 2025 at 5:41 PM Theodore Ts'o <tytso@....edu> wrote:
>
> On Mon, Apr 14, 2025 at 04:54:07PM +0000, Harshad Shirwadkar wrote:
> > V8 Cover Letter
> > ---------------
> >
> > This is the V8 of the patch series. This patch series contains fixes to
> > review comments by Jan Kara (<jack@...e.cz>). The main changes are as
> > follows:
>
> Hi Harshad,
>
> I tried applying your patch set on top of 6.15-rc3, and a number of
> tests: generic/127, generic/231, generic/241, generic/418, and
> generic/589 are causing the kernel to OOPS, wedge, or reboot.  Most of
> the test flakes and test failures were there without your patch set,
> and we need to figure them out.... but Errors are new, and are
> regressions.
>
> I can send you the test artifacts under separate cover, or you can
> just try running those tests using kvm-xfstests or gce-xfstests.
>
> Thanks,
>
>                                                         - Ted
>
> TESTRUNID: ltm-20250423233632
> KERNEL:    kernel 6.15.0-rc3-xfstests-00009-gac4ab1811bb3 #22 SMP PREEMPT_DYNAMIC Wed Apr 23 14:28:04 EDT 2025 x86_64
> CMDLINE:   --kernel gs://gce-xfstests/kernel.deb -c ext4/4k,ext4/fast_commit,ext4/fast_commit_1k -g auto
> CPUS:      2
> MEM:       7680
>
> ext4/4k: 587 tests, 55 skipped, 5243 seconds
> ext4/fast_commit: 602 tests, 20 failures, 3 errors, 55 skipped, 4564 seconds
>   Failures: generic/506 generic/737 generic/757 generic/764
>   Errors: generic/127 generic/241 generic/418
> ext4/fast_commit_1k: 616 tests, 39 failures, 5 errors, 59 skipped, 6169 seconds
>   Failures: generic/047 generic/051 generic/455 generic/475 generic/506
>     generic/757 generic/764
>   Flaky: generic/627: 80% (4/5)
>   Errors: generic/127 generic/231 generic/241 generic/418 generic/589
> Totals: 1805 tests, 169 skipped, 59 failures, 8 errors, 15637s
>