linux-ext4 - Re: [PATCH v3 2/2] check: Replace exit with _fatal and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bjsdqa5x.fsf@gmail.com>
Date: Thu, 01 May 2025 09:01:22 +0530
From: Ritesh Harjani (IBM) <ritesh.list@...il.com>
To: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@...il.com>, fstests@...r.kernel.org
Cc: linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org, ojaswin@...ux.ibm.com, djwong@...nel.org, zlang@...nel.org, david@...morbit.com, hch@...radead.org, nirjhar.roy.lists@...il.com
Subject: Re: [PATCH v3 2/2] check: Replace exit with _fatal and _exit in check

"Nirjhar Roy (IBM)" <nirjhar.roy.lists@...il.com> writes:

> Some of the "status=<val>;exit" and "exit <val>" were not
> replaced with _exit <val> and _fatal. Doing it now.
>

Indeed a nice cleanup. The changes in this patch looks good to me. 

Please feel free to add: 
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@...il.com>


So I guess these couple of series was to cleanup exit routines from
common bash scripts. Do we plan to update the tests/ as well where
we call...
    status=X
    exit

...or updating tests/ is not needed since we didn't find any wrong usage of
"exit X" routines there?


Either ways - I think we might need to update the README at some point
in time which carries this snip. You might need to add that there are
helper routines like  _exit() and _fatal() perhaps for use in common
scripts.

<snip>
    To force a non-zero exit status use:
	status=1
	exit

    Note that:
	exit 1
    won't have the desired effect because of the way the exit trap
    works.


-ritesh