linux-ext4 - Re: [PATCH] ext4: added missing kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPXz4EO8vbVxksgftCaSXb3UgWa_oxrsiYVCkOQTz+4gYZ5k_A@mail.gmail.com>
Date: Fri, 2 May 2025 15:26:22 -0700
From: Nicolas Bretz <bretznic@...il.com>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: linux-ext4@...r.kernel.org, tytso@....edu, jack@...e.cz, 
	adilger.kernel@...ger.ca
Subject: Re: [PATCH] ext4: added missing kfree

On Fri, May 2, 2025 at 1:37 PM Darrick J. Wong <djwong@...nel.org> wrote:
>
> On Fri, May 02, 2025 at 10:40:12AM -0700, Nicolas Bretz wrote:
> > Added one missing kfree to fsmap.c
> >
> > Signed-off-by: Nicolas Bretz <bretznic@...il.com>
> > ---
> >  fs/ext4/fsmap.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/fs/ext4/fsmap.c b/fs/ext4/fsmap.c
> > index b232c2767534..d41210abea0c 100644
> > --- a/fs/ext4/fsmap.c
> > +++ b/fs/ext4/fsmap.c
> > @@ -304,6 +304,7 @@ static inline int ext4_getfsmap_fill(struct list_head *meta_list,
> >       fsm->fmr_length = len;
> >       list_add_tail(&fsm->fmr_list, meta_list);
> >
> > +     kfree(fsm);
>
> OI: UAF, NAK.
>
> --D

I apologize, it definitely wasn't my intention. I guess not really
putting my best foot forward...
I don't yet fully get the UAF in this instance, but I'm studying it.

>
> >       return 0;
> >  }
> >
> > --
> > 2.43.0
> >
> >