linux-ext4 - Re: [PATCH v11 06/16] xfs: ignore HW which cannot atomic write a single block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d0e85d5-5e5c-4a8c-ae97-d90092c2c296@oracle.com>
Date: Mon, 5 May 2025 06:45:29 +0100
From: John Garry <john.g.garry@...cle.com>
To: Christoph Hellwig <hch@....de>
Cc: brauner@...nel.org, djwong@...nel.org, viro@...iv.linux.org.uk,
        jack@...e.cz, cem@...nel.org, linux-fsdevel@...r.kernel.org,
        dchinner@...hat.com, linux-xfs@...r.kernel.org,
        linux-kernel@...r.kernel.org, ojaswin@...ux.ibm.com,
        ritesh.list@...il.com, martin.petersen@...cle.com,
        linux-ext4@...r.kernel.org, linux-block@...r.kernel.org,
        catherine.hoang@...cle.com, linux-api@...r.kernel.org
Subject: Re: [PATCH v11 06/16] xfs: ignore HW which cannot atomic write a
 single block

On 05/05/2025 06:43, Christoph Hellwig wrote:
> I think this subject line here is left from an earlier version and
> doesn't quite seem to summarize what this patch is doing now?
> 
>> +extern int xfs_configure_buftarg(struct xfs_buftarg *, unsigned int);
> 
> Please drop the extern and spell out the parameter name while you're at
> it.

I can fix all this, if Darrick does not beat me to it.

> 
> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@....de>
> 


cheers