lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250506042242.GA26378@lst.de> Date: Tue, 6 May 2025 06:22:42 +0200 From: Christoph Hellwig <hch@....de> To: John Garry <john.g.garry@...cle.com> Cc: "Darrick J. Wong" <djwong@...nel.org>, Christoph Hellwig <hch@....de>, brauner@...nel.org, viro@...iv.linux.org.uk, jack@...e.cz, cem@...nel.org, linux-fsdevel@...r.kernel.org, dchinner@...hat.com, linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org, ojaswin@...ux.ibm.com, ritesh.list@...il.com, martin.petersen@...cle.com, linux-ext4@...r.kernel.org, linux-block@...r.kernel.org, catherine.hoang@...cle.com, linux-api@...r.kernel.org Subject: Re: [PATCH v11 02/16] xfs: only call xfs_setsize_buftarg once per buffer target On Mon, May 05, 2025 at 04:27:56PM +0100, John Garry wrote: > On 05/05/2025 15:48, John Garry wrote: >>>> @Darrick, please comment on whether happy with changes discussed. >>> I put the sync_blockdev calls in a separate function so that the >>> EIO/ENOSPC/whatever errors that come from the block device sync don't >>> get morphed into ENOMEM by xfs_alloc_buftarg before being passed up. I >>> suppose we could make that function return an ERR_PTR, but I was trying >>> to avoid making even more changes at the last minute, again. >> >> It seems simpler to just have the individual sync_blockdev() calls from >> xfs_alloc_buftarg(), rather than adding ERR_PTR() et al handling in both >> xfs_alloc_buftarg() and xfs_open_devices(). > > Which of the following is better: To me version 2 looks much better. I had initial reservations as ERR_PTR doesn't play well with userspace, but none of this code is in libxfs, so that should be fine.
Powered by blists - more mailing lists