linux-ext4 - Re: [PATCH v3 0/2] common: Move exit related functions to common/exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aefede43-9ac6-43bb-a22a-47dc0f4c8cd9@gmail.com>
Date: Tue, 6 May 2025 14:19:07 +0530
From: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@...il.com>
To: fstests@...r.kernel.org
Cc: linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org,
 ritesh.list@...il.com, ojaswin@...ux.ibm.com, djwong@...nel.org,
 zlang@...nel.org, david@...morbit.com, hch@...radead.org
Subject: Re: [PATCH v3 0/2] common: Move exit related functions to common/exit


On 4/30/25 18:15, Nirjhar Roy (IBM) wrote:
> This patch series moves all the exit related functions to a separate file -
> common/exit. This will remove the dependency to source non-related files to use
> these exit related functions. Thanks to Dave for suggesting this[1]. The second
> patch replaces exit with _exit in check file - I missed replacing them in [2].
>
> [v2] -> v3
>   Addressed Dave's feedbacks.
>   In patch [1/2]
>    - Removed _die() and die_now() from common/exit
>    - Replaced die_now() with _fatal in common/punch
>    - Removed sourcing of common/exit and common/test_names from common/config
>      and moved them to the beginning of check.
>    - Added sourcing of common/test_names in _begin_fstest() since common/config
>      is no more sourcing common/test_names.
>    - Added a blank line in _begin_fstest() after sourcing common/{exit,test_names}
>   In patch [2/2]
>    - Replaced "_exit 1" with _fatal and "echo <error message>; _exit 1" with
>     _fatal <error message>.
>    - Reverted to "exit \$status" in the trap handler registration in check - just
>      to make it more obvious to the reader that we are capturing $status as the
>      final exit value.

Hi Dave and Zorro,

Any further feedback in this version?

--NR

>
> [v1] https://lore.kernel.org/all/cover.1745390030.git.nirjhar.roy.lists@gmail.com/
> [v2] https://lore.kernel.org/all/cover.1745908976.git.nirjhar.roy.lists@gmail.com/
> [1] https://lore.kernel.org/all/Z_UJ7XcpmtkPRhTr@dread.disaster.area/
> [2] https://lore.kernel.org/all/48dacdf636be19ae8bff66cc3852d27e28030613.1744181682.git.nirjhar.roy.lists@gmail.com/
>
>
> Nirjhar Roy (IBM) (2):
>    common: Move exit related functions to a common/exit
>    check: Replace exit with _fatal and _exit in check
>
>   check           | 54 ++++++++++++++++++-------------------------------
>   common/config   | 17 ----------------
>   common/exit     | 39 +++++++++++++++++++++++++++++++++++
>   common/preamble |  3 +++
>   common/punch    | 39 ++++++++++++++++-------------------
>   common/rc       | 28 -------------------------
>   6 files changed, 79 insertions(+), 101 deletions(-)
>   create mode 100644 common/exit
>
> --
> 2.34.1
>
-- 
Nirjhar Roy
Linux Kernel Developer
IBM, Bangalore