| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20250513100730.12664-41-byungchul@sk.com>
Date: Tue, 13 May 2025 19:07:27 +0900
From: Byungchul Park <byungchul@...com>
To: linux-kernel@...r.kernel.org
Cc: kernel_team@...ynix.com,
torvalds@...ux-foundation.org,
damien.lemoal@...nsource.wdc.com,
linux-ide@...r.kernel.org,
adilger.kernel@...ger.ca,
linux-ext4@...r.kernel.org,
mingo@...hat.com,
peterz@...radead.org,
will@...nel.org,
tglx@...utronix.de,
rostedt@...dmis.org,
joel@...lfernandes.org,
sashal@...nel.org,
daniel.vetter@...ll.ch,
duyuyang@...il.com,
johannes.berg@...el.com,
tj@...nel.org,
tytso@....edu,
willy@...radead.org,
david@...morbit.com,
amir73il@...il.com,
gregkh@...uxfoundation.org,
kernel-team@....com,
linux-mm@...ck.org,
akpm@...ux-foundation.org,
mhocko@...nel.org,
minchan@...nel.org,
hannes@...xchg.org,
vdavydov.dev@...il.com,
sj@...nel.org,
jglisse@...hat.com,
dennis@...nel.org,
cl@...ux.com,
penberg@...nel.org,
rientjes@...gle.com,
vbabka@...e.cz,
ngupta@...are.org,
linux-block@...r.kernel.org,
josef@...icpanda.com,
linux-fsdevel@...r.kernel.org,
jack@...e.cz,
jlayton@...nel.org,
dan.j.williams@...el.com,
hch@...radead.org,
djwong@...nel.org,
dri-devel@...ts.freedesktop.org,
rodrigosiqueiramelo@...il.com,
melissa.srw@...il.com,
hamohammed.sa@...il.com,
harry.yoo@...cle.com,
chris.p.wilson@...el.com,
gwan-gyeong.mun@...el.com,
max.byungchul.park@...il.com,
boqun.feng@...il.com,
longman@...hat.com,
yskelg@...il.com,
yunseong.kim@...csson.com,
yeoreum.yun@....com,
netdev@...r.kernel.org,
matthew.brost@...el.com,
her0gyugyu@...il.com
Subject: [PATCH v15 40/43] dept: add module support for struct dept_event_site and dept_event_site_dep
struct dept_event_site and struct dept_event_site_dep have been
introduced to track dependencies between multi event sites for a single
wait, that will be loaded to data segment. Plus, a custom section,
'.dept.event_sites', also has been introduced to keep pointers to the
objects to make sure all the event sites defined exist in code.
dept should work with the section and segment of module. Add the
support to handle the section and segment properly whenever modules are
loaded and unloaded.
Signed-off-by: Byungchul Park <byungchul@...com>
---
include/linux/dept.h | 14 +++++++
include/linux/module.h | 5 +++
kernel/dependency/dept.c | 79 +++++++++++++++++++++++++++++++++++-----
kernel/module/main.c | 15 ++++++++
4 files changed, 103 insertions(+), 10 deletions(-)
diff --git a/include/linux/dept.h b/include/linux/dept.h
index b933f9d98c69..a97f34d62468 100644
--- a/include/linux/dept.h
+++ b/include/linux/dept.h
@@ -419,6 +419,11 @@ struct dept_event_site {
struct dept_event_site *bfs_parent;
struct list_head bfs_node;
+ /*
+ * for linking all dept_event_site's
+ */
+ struct list_head all_node;
+
/*
* flag indicating the event is not only declared but also
* actually used in code
@@ -435,6 +440,11 @@ struct dept_event_site_dep {
*/
struct list_head dep_node;
struct list_head dep_rev_node;
+
+ /*
+ * for linking all dept_event_site_dep's
+ */
+ struct list_head all_node;
};
#define DEPT_EVENT_SITE_INITIALIZER(es) \
@@ -446,6 +456,7 @@ struct dept_event_site_dep {
.bfs_gen = 0, \
.bfs_parent = NULL, \
.bfs_node = LIST_HEAD_INIT((es).bfs_node), \
+ .all_node = LIST_HEAD_INIT((es).all_node), \
.used = false, \
}
@@ -455,6 +466,7 @@ struct dept_event_site_dep {
.recover_site = NULL, \
.dep_node = LIST_HEAD_INIT((esd).dep_node), \
.dep_rev_node = LIST_HEAD_INIT((esd).dep_rev_node), \
+ .all_node = LIST_HEAD_INIT((esd).all_node), \
}
struct dept_event_site_init {
@@ -478,6 +490,7 @@ extern void dept_init(void);
extern void dept_task_init(struct task_struct *t);
extern void dept_task_exit(struct task_struct *t);
extern void dept_free_range(void *start, unsigned int sz);
+extern void dept_mark_event_site_used(void *start, void *end);
extern void dept_map_init(struct dept_map *m, struct dept_key *k, int sub_u, const char *n);
extern void dept_map_reinit(struct dept_map *m, struct dept_key *k, int sub_u, const char *n);
@@ -541,6 +554,7 @@ struct dept_event_site { };
#define dept_task_init(t) do { } while (0)
#define dept_task_exit(t) do { } while (0)
#define dept_free_range(s, sz) do { } while (0)
+#define dept_mark_event_site_used(s, e) do { } while (0)
#define dept_map_init(m, k, su, n) do { (void)(n); (void)(k); } while (0)
#define dept_map_reinit(m, k, su, n) do { (void)(n); (void)(k); } while (0)
diff --git a/include/linux/module.h b/include/linux/module.h
index b3329110d668..3da466a2c705 100644
--- a/include/linux/module.h
+++ b/include/linux/module.h
@@ -28,6 +28,7 @@
#include <linux/srcu.h>
#include <linux/static_call_types.h>
#include <linux/dynamic_debug.h>
+#include <linux/dept.h>
#include <linux/percpu.h>
#include <asm/module.h>
@@ -599,6 +600,10 @@ struct module {
#ifdef CONFIG_DYNAMIC_DEBUG_CORE
struct _ddebug_info dyndbg_info;
#endif
+#ifdef CONFIG_DEPT
+ struct dept_event_site **dept_event_sites;
+ unsigned int num_dept_event_sites;
+#endif
} ____cacheline_aligned __randomize_layout;
#ifndef MODULE_ARCH_INIT
#define MODULE_ARCH_INIT {}
diff --git a/kernel/dependency/dept.c b/kernel/dependency/dept.c
index b7167ce4f647..bd46c2ce84eb 100644
--- a/kernel/dependency/dept.c
+++ b/kernel/dependency/dept.c
@@ -990,6 +990,9 @@ static void bfs(void *root, struct bfs_ops *ops, void *in, void **out)
* event sites.
*/
+static LIST_HEAD(dept_event_sites);
+static LIST_HEAD(dept_event_site_deps);
+
/*
* Print all events in the circle.
*/
@@ -2053,6 +2056,33 @@ static void del_dep_rcu(struct rcu_head *rh)
preempt_enable();
}
+/*
+ * NOTE: Must be called with dept_lock held.
+ */
+static void disconnect_event_site_dep(struct dept_event_site_dep *esd)
+{
+ list_del_rcu(&esd->dep_node);
+ list_del_rcu(&esd->dep_rev_node);
+}
+
+/*
+ * NOTE: Must be called with dept_lock held.
+ */
+static void disconnect_event_site(struct dept_event_site *es)
+{
+ struct dept_event_site_dep *esd, *next_esd;
+
+ list_for_each_entry_safe(esd, next_esd, &es->dep_head, dep_node) {
+ list_del_rcu(&esd->dep_node);
+ list_del_rcu(&esd->dep_rev_node);
+ }
+
+ list_for_each_entry_safe(esd, next_esd, &es->dep_rev_head, dep_rev_node) {
+ list_del_rcu(&esd->dep_node);
+ list_del_rcu(&esd->dep_rev_node);
+ }
+}
+
/*
* NOTE: Must be called with dept_lock held.
*/
@@ -2396,6 +2426,8 @@ void dept_free_range(void *start, unsigned int sz)
{
struct dept_task *dt = dept_task();
struct dept_class *c, *n;
+ struct dept_event_site_dep *esd, *next_esd;
+ struct dept_event_site *es, *next_es;
unsigned long flags;
if (unlikely(!dept_working()))
@@ -2417,6 +2449,24 @@ void dept_free_range(void *start, unsigned int sz)
while (unlikely(!dept_lock()))
cpu_relax();
+ list_for_each_entry_safe(esd, next_esd, &dept_event_site_deps, all_node) {
+ if (!within((void *)esd, start, sz))
+ continue;
+
+ disconnect_event_site_dep(esd);
+ list_del(&esd->all_node);
+ }
+
+ list_for_each_entry_safe(es, next_es, &dept_event_sites, all_node) {
+ if (!within((void *)es, start, sz) &&
+ !within(es->name, start, sz) &&
+ !within(es->func_name, start, sz))
+ continue;
+
+ disconnect_event_site(es);
+ list_del(&es->all_node);
+ }
+
list_for_each_entry_safe(c, n, &dept_classes, all_node) {
if (!within((void *)c->key, start, sz) &&
!within(c->name, start, sz))
@@ -3348,6 +3398,7 @@ void __dept_recover_event(struct dept_event_site_dep *esd,
list_add(&esd->dep_node, &es->dep_head);
list_add(&esd->dep_rev_node, &rs->dep_rev_head);
+ list_add(&esd->all_node, &dept_event_site_deps);
check_recover_dl_bfs(esd);
unlock:
dept_unlock();
@@ -3358,6 +3409,23 @@ EXPORT_SYMBOL_GPL(__dept_recover_event);
#define B2KB(B) ((B) / 1024)
+void dept_mark_event_site_used(void *start, void *end)
+{
+ struct dept_event_site_init **evtinitpp;
+
+ for (evtinitpp = (struct dept_event_site_init **)start;
+ evtinitpp < (struct dept_event_site_init **)end;
+ evtinitpp++) {
+ (*evtinitpp)->evt_site->used = true;
+ (*evtinitpp)->evt_site->func_name = (*evtinitpp)->func_name;
+ list_add(&(*evtinitpp)->evt_site->all_node, &dept_event_sites);
+
+ pr_info("dept_event_site %s@%s is initialized.\n",
+ (*evtinitpp)->evt_site->name,
+ (*evtinitpp)->evt_site->func_name);
+ }
+}
+
extern char __dept_event_sites_start[], __dept_event_sites_end[];
/*
@@ -3367,20 +3435,11 @@ extern char __dept_event_sites_start[], __dept_event_sites_end[];
void __init dept_init(void)
{
size_t mem_total = 0;
- struct dept_event_site_init **evtinitpp;
/*
* dept recover dependency tracking works from now on.
*/
- for (evtinitpp = (struct dept_event_site_init **)__dept_event_sites_start;
- evtinitpp < (struct dept_event_site_init **)__dept_event_sites_end;
- evtinitpp++) {
- (*evtinitpp)->evt_site->used = true;
- (*evtinitpp)->evt_site->func_name = (*evtinitpp)->func_name;
- pr_info("dept_event %s@%s is initialized.\n",
- (*evtinitpp)->evt_site->name,
- (*evtinitpp)->evt_site->func_name);
- }
+ dept_mark_event_site_used(__dept_event_sites_start, __dept_event_sites_end);
dept_recover_ready = true;
local_irq_disable();
diff --git a/kernel/module/main.c b/kernel/module/main.c
index 7e569e1b4db5..1c439ed8c9ed 100644
--- a/kernel/module/main.c
+++ b/kernel/module/main.c
@@ -2611,6 +2611,11 @@ static int find_module_sections(struct module *mod, struct load_info *info)
&mod->dyndbg_info.num_classes);
#endif
+#ifdef CONFIG_DEPT
+ mod->dept_event_sites = section_objs(info, ".dept.event_sites",
+ sizeof(*mod->dept_event_sites),
+ &mod->num_dept_event_sites);
+#endif
return 0;
}
@@ -3249,6 +3254,14 @@ static int early_mod_check(struct load_info *info, int flags)
return err;
}
+static void dept_mark_event_site_used_module(struct module *mod)
+{
+#ifdef CONFIG_DEPT
+ dept_mark_event_site_used(mod->dept_event_sites,
+ mod->dept_event_sites + mod->num_dept_event_sites);
+#endif
+}
+
/*
* Allocate and load the module: note that size of section 0 is always
* zero, and we rely on this for optional sections.
@@ -3408,6 +3421,8 @@ static int load_module(struct load_info *info, const char __user *uargs,
/* Done! */
trace_module_load(mod);
+ dept_mark_event_site_used_module(mod);
+
return do_init_module(mod);
sysfs_cleanup:
--
2.17.1
Powered by blists - more mailing lists