linux-ext4 - Re: [PATCH v1 3/3] new: Run make after adding a new test file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250514051601.xj2lzfcmvruovorm@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>
Date: Wed, 14 May 2025 13:16:01 +0800
From: Zorro Lang <zlang@...hat.com>
To: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@...il.com>
Cc: fstests@...r.kernel.org, linux-ext4@...r.kernel.org,
	linux-xfs@...r.kernel.org, ritesh.list@...il.com,
	ojaswin@...ux.ibm.com, djwong@...nel.org, zlang@...nel.org,
	david@...morbit.com
Subject: Re: [PATCH v1 3/3] new: Run make after adding a new test file

On Tue, May 13, 2025 at 08:10:12AM +0000, Nirjhar Roy (IBM) wrote:
> Once a new test file is created, it needs to explicitly
> added to the group.list file in tests/<FSTYPE> directory
> in order for it to get run. Automate
> that by running make by as a part of creation of the new
> test file in the "new" script.

I think it's not necessary to force to do that, the users can do "make -jN"
when they need :)

> 
> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@...il.com>
> ---
>  new | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/new b/new
> index e55830ce..647763c1 100755
> --- a/new
> +++ b/new
> @@ -191,5 +191,13 @@ QA output created by $id
>  Silence is golden
>  End-of-File
>  
> +echo "Adding test $tdir/$id to the test list..."
> +make >> /dev/null 2>&1 || true
> +
> +if ! grep -q $id $tdir/group.list; then
> +	echo "$tdir/$id created but not added to the $tdir/group.list."
> +	echo "Possible reason is make failure. Please ensure a clean build"
> +fi
> +
>  echo " done."
>  exit 0
> -- 
> 2.34.1
> 
>