linux-ext4 - Re: [PATCH] ext4: avoid -Wformat-security warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <174775151764.432196.13613749014255693736.b4-ty@mit.edu>
Date: Tue, 20 May 2025 10:40:10 -0400
From: "Theodore Ts'o" <tytso@....edu>
To: Andreas Dilger <adilger.kernel@...ger.ca>, Arnd Bergmann <arnd@...nel.org>
Cc: "Theodore Ts'o" <tytso@....edu>, Arnd Bergmann <arnd@...db.de>,
        Jan Kara <jack@...e.cz>, Zhang Yi <yi.zhang@...wei.com>,
        Ojaswin Mujoo <ojaswin@...ux.ibm.com>,
        "Darrick J. Wong" <djwong@...nel.org>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        "Ritesh Harjani (IBM)" <ritesh.list@...il.com>,
        Shida Zhang <zhangshida@...inos.cn>, Baokun Li <libaokun1@...wei.com>,
        Jann Horn <jannh@...gle.com>, Brian Foster <bfoster@...hat.com>,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4: avoid -Wformat-security warning


On Wed, 23 Apr 2025 18:43:49 +0200, Arnd Bergmann wrote:
> check_igot_inode() prints a variable string, which causes a harmless
> warning with 'make W=1':
> 
> fs/ext4/inode.c:4763:45: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
>  4763 |         ext4_error_inode(inode, function, line, 0, err_str);
> 
> Use a trivial "%s" format string instead.
> 
> [...]

Applied, thanks!

[1/1] ext4: avoid -Wformat-security warning
      commit: d612a07931e261c537978aad096e7340b687cd0c

Best regards,
-- 
Theodore Ts'o <tytso@....edu>