linux-ext4 - Re: [PATCH 1/3] misc: deduplicate log2/log10 functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <174783906008.866336.9418124826859304764.b4-ty@mit.edu>
Date: Wed, 21 May 2025 10:50:59 -0400
From: "Theodore Ts'o" <tytso@....edu>
To: Andreas Dilger <adilger@...mcloud.com>
Cc: "Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org,
        Li Dongyang <dongyangli@....com>
Subject: Re: [PATCH 1/3] misc: deduplicate log2/log10 functions


On Fri, 24 Jan 2025 17:42:18 -0700, Andreas Dilger wrote:
> Remove duplicate log2() and log10() functions and replace them with
> functions ext2fs_log2_u{32,64}() and ext2fs_log10_u{32,64}().
> 
> The int_log10() functions in progress.c and mke2fs.c were not like
> the others, since they did not divide by the base before increment,
> effectively rounding up instead of down.  Compensate by adding one
> to the returned ext2fs_log10_u32() value at the callers.
> 
> [...]

Applied, thanks!

[1/3] misc: deduplicate log2/log10 functions
      commit: be4834c29e6f2c55ab6e6c9c94b95b46e24cfdb4
[2/3] journal: increase revoke block hash size
      commit: c2f2f0cdf5ad5f281582d810a0c48c612142a08b

Best regards,
-- 
Theodore Ts'o <tytso@....edu>