linux-ext4 - [PATCH 03/29] fuse2fs: clean up error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <174786677603.1383760.817536477752866097.stgit@frogsfrogsfrogs>
Date: Wed, 21 May 2025 15:35:41 -0700
From: "Darrick J. Wong" <djwong@...nel.org>
To: tytso@....edu
Cc: linux-ext4@...r.kernel.org
Subject: [PATCH 03/29] fuse2fs: clean up error messages

From: Darrick J. Wong <djwong@...nel.org>

Instead of horridly line-wrapping multi-line messages that are printed
during mounting, let's just expand them to be one source code line per
printed line.  This will make it a lot easier for someone who sees the
these errors to grep the source code to find out where they came from.

Signed-off-by: "Darrick J. Wong" <djwong@...nel.org>
---
 misc/fuse2fs.c |   14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)


diff --git a/misc/fuse2fs.c b/misc/fuse2fs.c
index 58c80c5c9a1ea2..8d52e00e3ece48 100644
--- a/misc/fuse2fs.c
+++ b/misc/fuse2fs.c
@@ -4023,8 +4023,7 @@ int main(int argc, char *argv[])
 	if (ext2fs_has_feature_journal_needs_recovery(global_fs->super)) {
 		if (fctx.norecovery) {
 			log_printf(&fctx, "%s\n",
-				   _("Mounting read-only without "
-				     "recovering journal."));
+ _("Mounting read-only without recovering journal."));
 			fctx.ro = 1;
 			global_fs->flags &= ~EXT2_FLAG_RW;
 		} else {
@@ -4043,13 +4042,10 @@ int main(int argc, char *argv[])
 
 	if (global_fs->flags & EXT2_FLAG_RW) {
 		if (ext2fs_has_feature_journal(global_fs->super))
-			log_printf(&fctx, "%s\n",
-				   _("Warning: fuse2fs does not support "
-				     "using the\n"
-				     "journal.  There may be file system "
-				     "corruption or data loss if\n"
-				     "the file system is not gracefully "
-				     "unmounted.\n"));
+			log_printf(&fctx, "%s",
+ _("Warning: fuse2fs does not support using the journal.\n"
+   "There may be file system corruption or data loss if\n"
+   "the file system is not gracefully unmounted.\n"));
 		err = ext2fs_read_inode_bitmap(global_fs);
 		if (err) {
 			translate_error(global_fs, 0, err);