linux-ext4 - Re: [PATCH] ext4: remove unnecessary duplicate check in ext4_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ldqm39pu.fsf@gmail.com>
Date: Sat, 24 May 2025 10:07:33 +0530
From: Ritesh Harjani (IBM) <ritesh.list@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Theodore Ts'o <tytso@....edu>, Andreas Dilger <adilger.kernel@...ger.ca>, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ext4: remove unnecessary duplicate check in ext4_map_blocks()

Dan Carpenter <dan.carpenter@...aro.org> writes:

> The previous lines ensure that EXT4_GET_BLOCKS_QUERY_LAST_IN_LEAF is
> set so remove this duplicate check.
>

Earlier, I knew it was a redundant check, but I went ahead with it
anyway; and later, I might have missed removing it. I agree that we
don’t really need this extra check.

So, the patch looks good to me. Thanks for taking care of it!

Please feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@...il.com>


> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  fs/ext4/inode.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index be9a4cba35fd..014021019b22 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -757,8 +757,7 @@ int ext4_map_blocks(handle_t *handle, struct inode *inode,
>  				orig_mlen == map->m_len)
>  			goto found;
>  
> -		if (flags & EXT4_GET_BLOCKS_QUERY_LAST_IN_LEAF)
> -			map->m_len = orig_mlen;
> +		map->m_len = orig_mlen;
>  	}
>  	/*
>  	 * In the query cache no-wait mode, nothing we can do more if we
> -- 
> 2.47.2