lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <i3x65oflf5uh6chfxcpbep6lvkbfmellgkm5edirg67amj6nfn@dvy3zldufkls> Date: Thu, 5 Jun 2025 15:44:00 +0200 From: Jan Kara <jack@...e.cz> To: Zhang Yi <yi.zhang@...weicloud.com> Cc: linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, tytso@....edu, adilger.kernel@...ger.ca, jack@...e.cz, ojaswin@...ux.ibm.com, yi.zhang@...wei.com, libaokun1@...wei.com, yukuai3@...wei.com, yangerkun@...wei.com Subject: Re: [PATCH 4/5] ext4: fix insufficient credits calculation in ext4_meta_trans_blocks() On Fri 30-05-25 14:28:57, Zhang Yi wrote: > From: Zhang Yi <yi.zhang@...wei.com> > > The calculation of journal credits in ext4_meta_trans_blocks() should > include pextents, as each extent separately may be allocated from a > different group and thus need to update different bitmap and group > descriptor block. > > Fixes: 0e32d8617012 ("ext4: correct the journal credits calculations of allocating blocks") > Reported-by:: Jan Kara <jack@...e.cz> > Closes: https://lore.kernel.org/linux-ext4/nhxfuu53wyacsrq7xqgxvgzcggyscu2tbabginahcygvmc45hy@t4fvmyeky33e/ > Signed-off-by: Zhang Yi <yi.zhang@...wei.com> Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@...e.cz> Honza > --- > fs/ext4/inode.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index 1818a2a7ba8f..e7de2fafc941 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -6184,7 +6184,7 @@ int ext4_meta_trans_blocks(struct inode *inode, int lblocks, int pextents) > int ret; > > /* > - * How many index and lead blocks need to touch to map @lblocks > + * How many index and leaf blocks need to touch to map @lblocks > * logical blocks to @pextents physical extents? > */ > idxblocks = ext4_index_trans_blocks(inode, lblocks, pextents); > @@ -6193,7 +6193,7 @@ int ext4_meta_trans_blocks(struct inode *inode, int lblocks, int pextents) > * Now let's see how many group bitmaps and group descriptors need > * to account > */ > - groups = idxblocks; > + groups = idxblocks + pextents; > gdpblocks = groups; > if (groups > ngroups) > groups = ngroups; > -- > 2.46.1 > -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists