[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6840facc407be_2491100d6@dwillia2-xfh.jf.intel.com.notmuch>
Date: Wed, 4 Jun 2025 19:02:52 -0700
From: Dan Williams <dan.j.williams@...el.com>
To: Alistair Popple <apopple@...dia.com>, <linux-mm@...ck.org>
CC: Alistair Popple <apopple@...dia.com>, <gerald.schaefer@...ux.ibm.com>,
<dan.j.williams@...el.com>, <jgg@...pe.ca>, <willy@...radead.org>,
<david@...hat.com>, <linux-kernel@...r.kernel.org>, <nvdimm@...ts.linux.dev>,
<linux-fsdevel@...r.kernel.org>, <linux-ext4@...r.kernel.org>,
<linux-xfs@...r.kernel.org>, <jhubbard@...dia.com>, <hch@....de>,
<zhang.lyra@...il.com>, <debug@...osinc.com>, <bjorn@...nel.org>,
<balbirs@...dia.com>, <lorenzo.stoakes@...cle.com>,
<linux-arm-kernel@...ts.infradead.org>, <loongarch@...ts.linux.dev>,
<linuxppc-dev@...ts.ozlabs.org>, <linux-riscv@...ts.infradead.org>,
<linux-cxl@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
<John@...ves.net>
Subject: Re: [PATCH 05/12] mm: Remove remaining uses of PFN_DEV
Alistair Popple wrote:
> PFN_DEV was used by callers of dax_direct_access() to figure out if the
> returned PFN is associated with a page using pfn_t_has_page() or
> not. However all DAX PFNs now require an assoicated ZONE_DEVICE page so can
> assume a page exists.
>
> Other users of PFN_DEV were setting it before calling
> vmf_insert_mixed(). This is unnecessary as it is no longer checked, instead
> relying on pfn_valid() to determine if there is an associated page or not.
>
> Signed-off-by: Alistair Popple <apopple@...dia.com>
> Reviewed-by: Christoph Hellwig <hch@....de>
Looks good,
Reviewed-by: Dan Williams <dan.j.williams@...el.com>
Powered by blists - more mailing lists