lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250611060900.GA4613@lst.de> Date: Wed, 11 Jun 2025 08:09:00 +0200 From: Christoph Hellwig <hch@....de> To: Zhang Yi <yi.zhang@...weicloud.com> Cc: linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org, linux-block@...r.kernel.org, dm-devel@...ts.linux.dev, linux-nvme@...ts.infradead.org, linux-scsi@...r.kernel.org, linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org, hch@....de, tytso@....edu, djwong@...nel.org, john.g.garry@...cle.com, bmarzins@...hat.com, chaitanyak@...dia.com, shinichiro.kawasaki@....com, brauner@...nel.org, martin.petersen@...cle.com, yi.zhang@...wei.com, chengzhihao1@...wei.com, yukuai3@...wei.com, yangerkun@...wei.com Subject: Re: [PATCH 01/10] block: introduce BLK_FEAT_WRITE_ZEROES_UNMAP to queue limits features On Wed, Jun 04, 2025 at 10:08:41AM +0800, Zhang Yi wrote: > +static ssize_t queue_write_zeroes_unmap_show(struct gendisk *disk, char *page) .. > +static int queue_write_zeroes_unmap_store(struct gendisk *disk, > + const char *page, size_t count, struct queue_limits *lim) We're probably getting close to wanting macros for the sysfs flags, similar to the one for the features (QUEUE_SYSFS_FEATURE). No need to do this now, just thinking along. > +/* supports unmap write zeroes command */ > +#define BLK_FEAT_WRITE_ZEROES_UNMAP ((__force blk_features_t)(1u << 17)) Should this be exposed through sysfs as a read-only value? Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@....de>
Powered by blists - more mailing lists