linux-ext4 - Re: [PATCH v2 1/5] drm/i915: Use kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_E8315EB273FA16ECA8DD46FDA3FC2A320A09@qq.com>
Date: Wed, 25 Jun 2025 18:41:58 +0800
From: Chentaotao <chentao325@...com>
To: Matthew Wilcox <willy@...radead.org>,
 陈涛涛 Taotao Chen <chentaotao@...iglobal.com>
Cc: "tytso@....edu" <tytso@....edu>, "hch@...radead.org" <hch@...radead.org>,
 "adilger.kernel@...ger.ca" <adilger.kernel@...ger.ca>,
 "brauner@...nel.org" <brauner@...nel.org>,
 "jani.nikula@...ux.intel.com" <jani.nikula@...ux.intel.com>,
 "rodrigo.vivi@...el.com" <rodrigo.vivi@...el.com>,
 "tursulin@...ulin.net" <tursulin@...ulin.net>,
 "airlied@...il.com" <airlied@...il.com>,
 "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
 "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
 "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
 "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
 "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
 "linux-mm@...ck.org" <linux-mm@...ck.org>,
 "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/5] drm/i915: Use kernel_write() in shmem object
 create


在 2025/6/24 20:23, Matthew Wilcox 写道:
> On Tue, Jun 24, 2025 at 12:12:04PM +0000, 陈涛涛 Taotao Chen wrote:
>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
>> @@ -637,8 +637,7 @@ i915_gem_object_create_shmem_from_data(struct drm_i915_private *i915,
>>   {
>>   	struct drm_i915_gem_object *obj;
>>   	struct file *file;
>> -	const struct address_space_operations *aops;
>> -	loff_t pos;
>> +	loff_t pos = 0;
>>   	int err;
> I think 'err' needs to become ssize_t to avoid writes larger than 2GB
> from being misinterpreted as errors.

Thanks for the great catch! I’ve changed int err; to ssize_t err; as you 
suggested.