linux-ext4 - Re: [PATCH v2] common/rc: add repair fsck flag -f for ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250626195347.qo2sjqrtdj3cdigy@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>
Date: Fri, 27 Jun 2025 03:53:47 +0800
From: Zorro Lang <zlang@...hat.com>
To: Theodore Ts'o <tytso@....edu>
Cc: Leah Rumancik <leah.rumancik@...il.com>, fstests@...r.kernel.org,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH v2] common/rc: add repair fsck flag -f for ext4

On Wed, Jun 25, 2025 at 11:51:25PM -0400, Theodore Ts'o wrote:
> On Wed, Jun 25, 2025 at 02:20:22PM -0700, Leah Rumancik wrote:
> > There is a descrepancy between the fsck flags for ext4 during
> > filesystem repair and filesystem checking which causes occasional test
> > failures. In particular, _check_generic_filesystems uses -f for force
> > checking, but _repair_scratch_fs does not. In some tests, such as
> > generic/441, we sometimes exit fsck repair early with the filesystem
> > being deemed "clean" but then _check_generic_filesystems finds issues
> > during the forced full check. Bringing these flags in sync fixes the
> > flakes.
> > 
> > Signed-off-by: Leah Rumancik <leah.rumancik@...il.com>
> 
> Reviewed-by: Theodore Ts'o <tytso@....edu>
> 
> Looks good to me, although I might suggest ammending or just dropping
> the comment:
> 
> >  	# Let's hope fsck -y suffices...
> 
> ... since obviously, for ext[234] it wasn't sufficient.   :-)

Thanks Ted, I'll remove it when I merge this patch :)

Thanks,
Zorro

> 
>     	  	     	 	     	    - Ted
>