linux-ext4 - Re: [PATCH] e2scrub: honor fstrim setting in e2scrub.conf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250630151945.GC9987@frogsfrogsfrogs>
Date: Mon, 30 Jun 2025 08:19:45 -0700
From: "Darrick J. Wong" <djwong@...nel.org>
To: Samuel Smith <satlug@...153.net>
Cc: linux-ext4@...r.kernel.org
Subject: Re: [PATCH] e2scrub: honor fstrim setting in e2scrub.conf

On Sat, Jun 28, 2025 at 12:14:15AM -0500, Samuel Smith wrote:
> The systemd service unconditionally passes -t to e2scrub, forcing
> fstrim to run after every scrub regardless of the fstrim setting
> in /etc/e2scrub.conf. Removing the hardcoded flag will allow users to
> control the behavior via the configuration file.
> 
> Signed-off-by: Samuel Smith <satlug@...153.net>

Now that there's a config file, we can indeed drop the explicit -t.

Reviewed-by: "Darrick J. Wong" <djwong@...nel.org>

--D

> ---
>  scrub/e2scrub@...rvice.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scrub/e2scrub@...rvice.in b/scrub/e2scrub@...rvice.in
> index 6425263c..3c9893c5 100644
> --- a/scrub/e2scrub@...rvice.in
> +++ b/scrub/e2scrub@...rvice.in
> @@ -16,5 +16,5 @@ User=root
>  IOSchedulingClass=idle
>  CPUSchedulingPolicy=idle
>  Environment=SERVICE_MODE=1
> -ExecStart=@...t_sbindir@...scrub -t %f
> +ExecStart=@...t_sbindir@...scrub %f
>  SyslogIdentifier=%N
> -- 
> 2.39.5
> 
>