lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <aGOC94DxPTx_vljt@infradead.org> Date: Mon, 30 Jun 2025 23:40:55 -0700 From: Christoph Hellwig <hch@...radead.org> To: Qu Wenruo <quwenruo.btrfs@....com> Cc: Christoph Hellwig <hch@...radead.org>, Qu Wenruo <wqu@...e.com>, linux-btrfs@...r.kernel.org, linux-fsdevel@...r.kernel.org, viro@...iv.linux.org.uk, brauner@...nel.org, jack@...e.cz, linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net, ntfs3@...ts.linux.dev, linux-xfs@...r.kernel.org Subject: Re: [PATCH v2 1/6] fs: enhance and rename shutdown() callback to remove_bdev() On Tue, Jul 01, 2025 at 04:05:03PM +0930, Qu Wenruo wrote: > > Please also rename the function so that they match the method name. > > I prefer not, and it is intentionally left as is. > > This give us a very clear view what a fs is expected to do. No. Mismatching method are an insane pest that makes refactoring or even just reading the code painful as hell. Nacked-by: Christoph Hellwig <hch@....de> without that.
Powered by blists - more mailing lists