lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250701124009.GA461416@mit.edu>
Date: Tue, 1 Jul 2025 08:40:09 -0400
From: "Theodore Ts'o" <tytso@....edu>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: zhangjian <zhangjian496@...wei.com>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] debugfs: fix printing for sequence in descriptor/revoke
 block

Also, to clarify the code, please
also change the parameter names in dump_descriptor_block,
dump_revoke_block, and dump_metadata_block from transaction to
sequence.  That will make it clear that what these functions do with
the parameter is to print the sequence number, and avoid the confusion
steming from:

		fprintf(out_file, "Dumping revoke block, sequence %u, at "
			"block %u:\n", transaction, blocknr);

Thanks,

						- Ted

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ