lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <y66ier4j3kqxagrm4ztdls4iqxpggaj2bt4nwtsi2hen2bgnn3@ph3cev64ie6w> Date: Wed, 2 Jul 2025 16:10:59 +0200 From: Jan Kara <jack@...e.cz> To: Zhang Yi <yi.zhang@...weicloud.com> Cc: linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, tytso@....edu, adilger.kernel@...ger.ca, jack@...e.cz, ojaswin@...ux.ibm.com, sashal@...nel.org, yi.zhang@...wei.com, libaokun1@...wei.com, yukuai3@...wei.com, yangerkun@...wei.com Subject: Re: [PATCH v3 04/10] ext4: refactor the block allocation process of ext4_page_mkwrite() On Tue 01-07-25 21:06:29, Zhang Yi wrote: > From: Zhang Yi <yi.zhang@...wei.com> > > The block allocation process and error handling in ext4_page_mkwrite() > is complex now. Refactor it by introducing a new helper function, > ext4_block_page_mkwrite(). It will call ext4_block_write_begin() to > allocate blocks instead of directly calling block_page_mkwrite(). > Preparing to implement retry logic in a subsequent patch to address > situations where the reserved journal credits are insufficient. > Additionally, this modification will help prevent potential deadlocks > that may occur when waiting for folio writeback while holding the > transaction handle. > > Suggested-by: Jan Kara <jack@...e.cz> > Signed-off-by: Zhang Yi <yi.zhang@...wei.com> Looks good! Feel free to add: Reviewed-by: Jan Kara <jack@...e.cz> One typo fix below: > + /* Start jorunal and allocate blocks */ ^^^ journal > + err = ext4_block_page_mkwrite(inode, folio, get_block); > if (err == -ENOSPC && ext4_should_retry_alloc(inode->i_sb, &retries)) > goto retry_alloc; > out_ret: Honza -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists