linux-ext4 - Re: [PATCH v3 01/10] ext4: process folios writeback in bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <abbdba63-2e15-4a11-844a-0423d0bc4a87@huaweicloud.com>
Date: Thu, 3 Jul 2025 10:03:48 +0800
From: Zhang Yi <yi.zhang@...weicloud.com>
To: Jan Kara <jack@...e.cz>
Cc: linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
 linux-kernel@...r.kernel.org, tytso@....edu, adilger.kernel@...ger.ca,
 ojaswin@...ux.ibm.com, sashal@...nel.org, yi.zhang@...wei.com,
 libaokun1@...wei.com, yukuai3@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH v3 01/10] ext4: process folios writeback in bytes

On 2025/7/2 22:00, Jan Kara wrote:
> On Tue 01-07-25 21:06:26, Zhang Yi wrote:
>> From: Zhang Yi <yi.zhang@...wei.com>
>>
>> Since ext4 supports large folios, processing writebacks in pages is no
>> longer appropriate, it can be modified to process writebacks in bytes.
>>
>> Suggested-by: Jan Kara <jack@...e.cz>
>> Signed-off-by: Zhang Yi <yi.zhang@...wei.com>
> 
> Just one small issue. With that fixed feel free to add:
> 
> Reviewed-by: Jan Kara <jack@...e.cz>
> 
>> @@ -2786,18 +2788,18 @@ static int ext4_do_writepages(struct mpage_da_data *mpd)
>>  		writeback_index = mapping->writeback_index;
>>  		if (writeback_index)
>>  			cycled = 0;
>> -		mpd->first_page = writeback_index;
>> -		mpd->last_page = -1;
>> +		mpd->start_pos = writeback_index << PAGE_SHIFT;
>> +		mpd->end_pos = -1;
> 
> Careful here. Previously last_page was unsigned long so -1 was fine but now
> loff_t is signed. So we should rather store LLONG_MAX here.
> 
> 									Honza

Ha, right! Sorry for missed this corner, will fix.

Thanks,
Yi.