linux-ext4 - Re: [PATCH 3/4] hfsplus: enable uncached buffer io support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3c4ac1ab5f7afbbd745f88c595ee1465fc2e9ac6.camel@dubeyko.com>
Date: Fri, 04 Jul 2025 10:45:27 -0700
From: Viacheslav Dubeyko <slava@...eyko.com>
To: Yangtao Li <frank.li@...o.com>, axboe@...nel.dk,
 aivazian.tigran@...il.com, 	viro@...iv.linux.org.uk, brauner@...nel.org,
 jack@...e.cz, linkinjeon@...nel.org, 	sj1557.seo@...sung.com,
 yuezhang.mo@...y.com, glaubitz@...sik.fu-berlin.de, 	shaggy@...nel.org,
 konishi.ryusuke@...il.com, 	almaz.alexandrovich@...agon-software.com,
 me@...copeland.com, 	willy@...radead.org, josef@...icpanda.com,
 kovalev@...linux.org, dave@...olabs.net, 	mhocko@...e.com,
 chentaotao@...iglobal.com
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org, 
	jfs-discussion@...ts.sourceforge.net, linux-nilfs@...r.kernel.org, 
	ntfs3@...ts.linux.dev, linux-karma-devel@...ts.sourceforge.net, 
	bpf@...r.kernel.org
Subject: Re: [PATCH 3/4] hfsplus: enable uncached buffer io support

On Thu, 2025-06-26 at 11:30 -0600, Yangtao Li wrote:
> Now cont_write_begin() support DONTCACHE mode, let's set
> FOP_DONTCACHE
> flag to enable uncached buffer io support for hfsplus.
> 
> Signed-off-by: Yangtao Li <frank.li@...o.com>
> ---
>  fs/hfsplus/inode.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c
> index 26cc150856b9..b790ffe92019 100644
> --- a/fs/hfsplus/inode.c
> +++ b/fs/hfsplus/inode.c
> @@ -372,6 +372,7 @@ static const struct file_operations
> hfsplus_file_operations = {
>  	.open		= hfsplus_file_open,
>  	.release	= hfsplus_file_release,
>  	.unlocked_ioctl = hfsplus_ioctl,
> +	.fop_flags	= FOP_DONTCACHE,
>  };
>  
>  struct inode *hfsplus_new_inode(struct super_block *sb, struct inode
> *dir,

The same question for HFS+. Because, it is again old and pretty
obsolete file system. :) The main use-case is simply support the
capability to mount HFS+ volume is created under Mac OS X, for example,
and to access the data there. What is the point to support this feature
in HFS+? Currently, around 200 xfstests fails in HFS/HFS+. We even
cannot test any new functionality properly. And guys reports bugs in
existing functionality. We need to be focused on this right now. Sorry,
HFS/HFS+ is not so good ground for implementing new features. :)
We really need to stabilize the existing functionality right now. And
we have a lot of work yet. :) 

Thanks,
Slava.