linux-ext4 - Re: [PATCH 3/3] ext4: refactor the inline directory conversion and new directory codepaths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202507130429.rPIzofCD-lkp@intel.com>
Date: Sun, 13 Jul 2025 05:12:55 +0800
From: kernel test robot <lkp@...el.com>
To: Theodore Ts'o <tytso@....edu>,
	Ext4 Developers List <linux-ext4@...r.kernel.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-hardening@...r.kernel.org,
	ethan@...ancedwards.com, Theodore Ts'o <tytso@....edu>
Subject: Re: [PATCH 3/3] ext4: refactor the inline directory conversion and
 new directory codepaths

Hi Theodore,

kernel test robot noticed the following build warnings:

[auto build test WARNING on tytso-ext4/dev]
[also build test WARNING on linus/master v6.16-rc5 next-20250711]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Theodore-Ts-o/ext4-use-memcpy-instead-of-strcpy/20250713-021635
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
patch link:    https://lore.kernel.org/r/20250712181249.434530-3-tytso%40mit.edu
patch subject: [PATCH 3/3] ext4: refactor the inline directory conversion and new directory codepaths
config: i386-buildonly-randconfig-004-20250713 (https://download.01.org/0day-ci/archive/20250713/202507130429.rPIzofCD-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250713/202507130429.rPIzofCD-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507130429.rPIzofCD-lkp@intel.com/

All warnings (new ones prefixed by >>):

   fs/ext4/namei.c: In function 'ext4_init_new_dir':
>> fs/ext4/namei.c:2968:34: warning: variable 'de' set but not used [-Wunused-but-set-variable]
    2968 |         struct ext4_dir_entry_2 *de;
         |                                  ^~


vim +/de +2968 fs/ext4/namei.c

a774f9c20e0864 Tao Ma             2012-12-10  2963  
8016e29f4362e2 Harshad Shirwadkar 2020-10-15  2964  int ext4_init_new_dir(handle_t *handle, struct inode *dir,
a774f9c20e0864 Tao Ma             2012-12-10  2965  			     struct inode *inode)
ac27a0ec112a08 Dave Kleikamp      2006-10-11  2966  {
dabd991f9d8e32 Namhyung Kim       2011-01-10  2967  	struct buffer_head *dir_block = NULL;
617ba13b31fbf5 Mingming Cao       2006-10-11 @2968  	struct ext4_dir_entry_2 *de;
dc6982ff4db1f4 Theodore Ts'o      2013-02-14  2969  	ext4_lblk_t block = 0;
a774f9c20e0864 Tao Ma             2012-12-10  2970  	int err;
ac27a0ec112a08 Dave Kleikamp      2006-10-11  2971  
3c47d54170b6a6 Tao Ma             2012-12-10  2972  	if (ext4_test_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA)) {
3c47d54170b6a6 Tao Ma             2012-12-10  2973  		err = ext4_try_create_inline_dir(handle, dir, inode);
3c47d54170b6a6 Tao Ma             2012-12-10  2974  		if (err < 0 && err != -ENOSPC)
3c47d54170b6a6 Tao Ma             2012-12-10  2975  			goto out;
3c47d54170b6a6 Tao Ma             2012-12-10  2976  		if (!err)
3c47d54170b6a6 Tao Ma             2012-12-10  2977  			goto out;
3c47d54170b6a6 Tao Ma             2012-12-10  2978  	}
3c47d54170b6a6 Tao Ma             2012-12-10  2979  
5eb8361f6b02c3 Theodore Ts'o      2025-07-12  2980  	set_nlink(inode, 2);
dc6982ff4db1f4 Theodore Ts'o      2013-02-14  2981  	inode->i_size = 0;
0f70b40613ee14 Theodore Ts'o      2013-02-15  2982  	dir_block = ext4_append(handle, inode, &block);
0f70b40613ee14 Theodore Ts'o      2013-02-15  2983  	if (IS_ERR(dir_block))
0f70b40613ee14 Theodore Ts'o      2013-02-15  2984  		return PTR_ERR(dir_block);
a774f9c20e0864 Tao Ma             2012-12-10  2985  	de = (struct ext4_dir_entry_2 *)dir_block->b_data;
5eb8361f6b02c3 Theodore Ts'o      2025-07-12  2986  	err = ext4_init_dirblock(handle, inode, dir_block, dir->i_ino, NULL, 0);
a774f9c20e0864 Tao Ma             2012-12-10  2987  	if (err)
a774f9c20e0864 Tao Ma             2012-12-10  2988  		goto out;
a774f9c20e0864 Tao Ma             2012-12-10  2989  out:
a774f9c20e0864 Tao Ma             2012-12-10  2990  	brelse(dir_block);
a774f9c20e0864 Tao Ma             2012-12-10  2991  	return err;
a774f9c20e0864 Tao Ma             2012-12-10  2992  }
a774f9c20e0864 Tao Ma             2012-12-10  2993  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki