linux-ext4 - Re: [PATCH -next] ext4: fix the compile error of EXT4_MAX_PAGECACHE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f12e3ed-ad0e-4ca7-b26e-de7a7ac3a737@huawei.com>
Date: Tue, 15 Jul 2025 11:36:11 +0800
From: Baokun Li <libaokun1@...wei.com>
To: Zhang Yi <yi.zhang@...weicloud.com>
CC: <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<tytso@....edu>, <adilger.kernel@...ger.ca>, <jack@...e.cz>,
	<ojaswin@...ux.ibm.com>, <sfr@...b.auug.org.au>, <yi.zhang@...wei.com>,
	<yukuai3@...wei.com>, <yangerkun@...wei.com>, <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH -next] ext4: fix the compile error of
 EXT4_MAX_PAGECACHE_ORDER macro

On 2025/7/15 11:12, Zhang Yi wrote:
> From: Zhang Yi <yi.zhang@...wei.com>
>
> Since both the input and output parameters of the
> EXT4_MAX_PAGECACHE_ORDER should be unsigned int type, switch to using
> umin() instead of min(). This will silence the compile error reported by
> _compiletime_assert() on powerpc.
>
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Closes: https://lore.kernel.org/all/20250715082230.7f5bcb1e@canb.auug.org.au/
> Signed-off-by: Zhang Yi <yi.zhang@...wei.com>

Looks good. Feel free to add:

Reviewed-by: Baokun Li <libaokun1@...wei.com>

> ---
>   fs/ext4/inode.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 1bce9ebaedb7..6fd3692c4faf 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -5204,7 +5204,7 @@ static bool ext4_should_enable_large_folio(struct inode *inode)
>    * where the PAGE_SIZE exceeds 4KB.
>    */
>   #define EXT4_MAX_PAGECACHE_ORDER(i)		\
> -		min(MAX_PAGECACHE_ORDER, (11 + (i)->i_blkbits - PAGE_SHIFT))
> +		umin(MAX_PAGECACHE_ORDER, (11 + (i)->i_blkbits - PAGE_SHIFT))
>   void ext4_set_inode_mapping_order(struct inode *inode)
>   {
>   	if (!ext4_should_enable_large_folio(inode))