linux-ext4 - Re: [PATCH v4 07/11] generic: Stress fsx with atomic writes enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJwmY8_RLBVuTkDk@li-dc0c254c-257c-11b2-a85c-98b6c1322444.ibm.com>
Date: Wed, 13 Aug 2025 11:15:07 +0530
From: Ojaswin Mujoo <ojaswin@...ux.ibm.com>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: Zorro Lang <zlang@...hat.com>, fstests@...r.kernel.org,
        Ritesh Harjani <ritesh.list@...il.com>, john.g.garry@...cle.com,
        tytso@....edu, linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-ext4@...r.kernel.org
Subject: Re: [PATCH v4 07/11] generic: Stress fsx with atomic writes enabled

On Tue, Aug 12, 2025 at 10:18:55AM -0700, Darrick J. Wong wrote:
> On Sun, Aug 10, 2025 at 07:11:58PM +0530, Ojaswin Mujoo wrote:
> > Stress file with atomic writes to ensure we excercise codepaths
> > where we are mixing different FS operations with atomic writes
> > 
> > Suggested-by: Ritesh Harjani (IBM) <ritesh.list@...il.com>
> > Signed-off-by: Ojaswin Mujoo <ojaswin@...ux.ibm.com>
> 
> Didn't I already tag this
> Reviewed-by: "Darrick J. Wong" <djwong@...nel.org>

Yes you did but since I moved the fsx avoid logic from common/rc to here
I just thought it'd be better to remove old reviews.

(also fyi, i also removed the reviews from g/1227 for the same reason)

Thanks for the review again! 

Regards,
ojaswin
> 
> --D
> 
> > ---
> >  tests/generic/1229     | 68 ++++++++++++++++++++++++++++++++++++++++++
> >  tests/generic/1229.out |  2 ++
> >  2 files changed, 70 insertions(+)
> >  create mode 100755 tests/generic/1229
> >  create mode 100644 tests/generic/1229.out
> > 
> > diff --git a/tests/generic/1229 b/tests/generic/1229
> > new file mode 100755
> > index 00000000..7fa57105
> > --- /dev/null
> > +++ b/tests/generic/1229
> > @@ -0,0 +1,68 @@
> > +#! /bin/bash
> > +# SPDX-License-Identifier: GPL-2.0
> > +# Copyright (c) 2025 IBM Corporation. All Rights Reserved.
> > +#
> > +# FS QA Test 1229
> > +#
> > +# fuzz fsx with atomic writes
> > +#
> > +. ./common/preamble
> > +. ./common/atomicwrites
> > +_begin_fstest rw auto quick atomicwrites
> > +
> > +_require_odirect
> > +_require_scratch_write_atomic
> > +
> > +_scratch_mkfs >> $seqres.full 2>&1
> > +_scratch_mount  >> $seqres.full 2>&1
> > +
> > +testfile=$SCRATCH_MNT/testfile
> > +touch $testfile
> > +
> > +awu_max=$(_get_atomic_write_unit_max $testfile)
> > +blksz=$(_get_block_size $SCRATCH_MNT)
> > +bsize=`$here/src/min_dio_alignment $SCRATCH_MNT $SCRATCH_DEV`
> > +
> > +set_fsx_avoid() {
> > +	local file=$1
> > +
> > +	case "$FSTYP" in
> > +	"ext4")
> > +		local dev=$(findmnt -n -o SOURCE --target $testfile)
> > +
> > +		# fsx insert/collpase range support for ext4+bigalloc is
> > +		# currently broken, so disable it. Also disable incase we can't
> > +		# detect bigalloc to be on safer side.
> > +		if [ -z "$DUMPE2FS_PROG" ]; then
> > +			echo "dumpe2fs not found, disabling insert/collapse range" >> $seqres.full
> > +			FSX_AVOID+=" -I -C"
> > +			return
> > +		fi
> > +
> > +		$DUMPE2FS_PROG -h $dev 2>&1 | grep -q bigalloc && {
> > +			echo "fsx insert/collapse range not supported with bigalloc. Disabling.." >> $seqres.full
> > +			FSX_AVOID+=" -I -C"
> > +		}
> > +		;;
> > +	*)
> > +		;;
> > +	esac
> > +}
> > +
> > +# fsx usage:
> > +#
> > +# -N numops: total # operations to do
> > +# -l flen: the upper bound on file size
> > +# -o oplen: the upper bound on operation size (64k default)
> > +# -Z: O_DIRECT ()
> > +
> > +set_fsx_avoid
> > +_run_fsx_on_file $testfile -N 10000 -o $awu_max -A -l 500000 -r $bsize -w $bsize -Z $FSX_AVOID  >> $seqres.full
> > +if [[ "$?" != "0" ]]
> > +then
> > +	_fail "fsx returned error: $?"
> > +fi
> > +
> > +echo "Silence is golden"
> > +status=0
> > +exit
> > diff --git a/tests/generic/1229.out b/tests/generic/1229.out
> > new file mode 100644
> > index 00000000..737d61c6
> > --- /dev/null
> > +++ b/tests/generic/1229.out
> > @@ -0,0 +1,2 @@
> > +QA output created by 1229
> > +Silence is golden
> > -- 
> > 2.49.0
> > 
> >