linux-ext4 - Re: [PATCH RESEND] fs/ext4: remove unused variable 'de' in ext4_init_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250817234352.GH7938@frogsfrogsfrogs>
Date: Sun, 17 Aug 2025 16:43:52 -0700
From: "Darrick J. Wong" <djwong@...nel.org>
To: Suchit Karunakaran <suchitkarunakaran@...il.com>
Cc: tytso@....edu, adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-kernel-mentees@...ts.linux.dev,
	skhan@...uxfoundation.org
Subject: Re: [PATCH RESEND] fs/ext4: remove unused variable 'de' in
 ext4_init_new_dir()

On Wed, Aug 13, 2025 at 11:54:40PM +0530, Suchit Karunakaran wrote:
> The variable 'de' was declared but never used in the ext4_init_new_dir()
> function, causing a compiler warning:
> variable 'de' set but not used [-Werror=unused-but-set-variable]
> Remove the unused declaration to clean up the code and fix the warning.
> 
> Signed-off-by: Suchit Karunakaran <suchitkarunakaran@...il.com>

Gets rid of an annoying warning on my build system, so
Reviewed-by: "Darrick J. Wong" <djwong@...nel.org>

--D

> ---
>  fs/ext4/namei.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index d83f91b62317..bb2370829928 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -2965,7 +2965,6 @@ int ext4_init_new_dir(handle_t *handle, struct inode *dir,
>  			     struct inode *inode)
>  {
>  	struct buffer_head *dir_block = NULL;
> -	struct ext4_dir_entry_2 *de;
>  	ext4_lblk_t block = 0;
>  	int err;
>  
> @@ -2982,7 +2981,6 @@ int ext4_init_new_dir(handle_t *handle, struct inode *dir,
>  	dir_block = ext4_append(handle, inode, &block);
>  	if (IS_ERR(dir_block))
>  		return PTR_ERR(dir_block);
> -	de = (struct ext4_dir_entry_2 *)dir_block->b_data;
>  	err = ext4_init_dirblock(handle, inode, dir_block, dir->i_ino, NULL, 0);
>  	if (err)
>  		goto out;
> -- 
> 2.50.1
> 
>