lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <175573318622.4130038.48444777771831124.stgit@frogsfrogsfrogs>
Date: Wed, 20 Aug 2025 16:41:07 -0700
From: "Darrick J. Wong" <djwong@...nel.org>
To: tytso@....edu
Cc: linux-ext4@...r.kernel.org, linux-ext4@...r.kernel.org
Subject: [PATCH 01/12] mke2fs: don't print warnings about dax to stderr

From: Darrick J. Wong <djwong@...nel.org>

mke2fs prints a warning to standard error if the target device supports
fsdax but the fs block size doesn't match the page size.  This isn't an
error since we don't abort the format and the filesystem will work just
fine if the user doesn't care about fsdax.

Therefore, print the warning to stdout, not stderr.

Cc: <linux-ext4@...r.kernel.org> # v1.45.7
Fixes: f4979dd566acc4 ("mke2fs: Warn if fs block size is incompatible with DAX")
Signed-off-by: "Darrick J. Wong" <djwong@...nel.org>
---
 misc/mke2fs.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)


diff --git a/misc/mke2fs.c b/misc/mke2fs.c
index c84ace7a551222..7f81a5137501e0 100644
--- a/misc/mke2fs.c
+++ b/misc/mke2fs.c
@@ -2503,10 +2503,9 @@ static void PRS(int argc, char *argv[])
 		}
 
 		if (dev_param.dax && blocksize != sys_page_size) {
-			fprintf(stderr,
-				_("%s is capable of DAX but current block size "
-				  "%u is different from system page size %u so "
-				  "filesystem will not support DAX.\n"),
+			printf(_("%s is capable of DAX but current block size "
+				 "%u is different from system page size %u so "
+				 "filesystem will not support DAX.\n"),
 				device_name, blocksize, sys_page_size);
 		}
 	}


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ