| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202508222128.KZDs9G7n-lkp@intel.com>
Date: Fri, 22 Aug 2025 21:56:59 +0800
From: kernel test robot <lkp@...el.com>
To: Josef Bacik <josef@...icpanda.com>, linux-fsdevel@...r.kernel.org,
linux-btrfs@...r.kernel.org, kernel-team@...com,
linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org,
brauner@...nel.org, viro@...iv.linux.org.uk
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH 20/50] fs: convert i_count to refcount_t
Hi Josef,
kernel test robot noticed the following build errors:
[auto build test ERROR on brauner-vfs/vfs.all]
[also build test ERROR on kdave/for-next trace/for-next xfs-linux/for-next linus/master v6.17-rc2 next-20250822]
[cannot apply to tytso-ext4/dev]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Josef-Bacik/fs-add-an-i_obj_count-refcount-to-the-inode/20250822-045428
base: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all
patch link: https://lore.kernel.org/r/6a12e35a078d765b50bc7ced7030d6cd98065528.1755806649.git.josef%40toxicpanda.com
patch subject: [PATCH 20/50] fs: convert i_count to refcount_t
config: x86_64-randconfig-003-20250822 (https://download.01.org/0day-ci/archive/20250822/202508222128.KZDs9G7n-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250822/202508222128.KZDs9G7n-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508222128.KZDs9G7n-lkp@intel.com/
All errors (new ones prefixed by >>):
>> fs/smb/client/inode.c:2782:37: error: no member named 'counter' in 'struct refcount_struct'
2782 | full_path, inode, inode->i_count.counter,
| ~~~~~~~~~~~~~~ ^
fs/smb/client/cifs_debug.h:77:36: note: expanded from macro 'cifs_dbg'
77 | cifs_dbg_func(once, type, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
fs/smb/client/cifs_debug.h:66:23: note: expanded from macro 'cifs_dbg_func'
66 | __FILE__, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/printk.h:693:38: note: expanded from macro 'pr_debug_once'
693 | no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/printk.h:135:18: note: expanded from macro 'no_printk'
135 | _printk(fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
>> fs/smb/client/inode.c:2782:37: error: no member named 'counter' in 'struct refcount_struct'
2782 | full_path, inode, inode->i_count.counter,
| ~~~~~~~~~~~~~~ ^
fs/smb/client/cifs_debug.h:77:36: note: expanded from macro 'cifs_dbg'
77 | cifs_dbg_func(once, type, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
fs/smb/client/cifs_debug.h:68:38: note: expanded from macro 'cifs_dbg_func'
68 | pr_err_ ## ratefunc("VFS: " fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/printk.h:670:38: note: expanded from macro 'pr_err_once'
670 | printk_once(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
note: (skipping 2 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
include/linux/once_lite.h:31:9: note: expanded from macro 'DO_ONCE_LITE_IF'
31 | func(__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/printk.h:514:60: note: expanded from macro 'printk'
514 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/printk.h:486:19: note: expanded from macro 'printk_index_wrap'
486 | _p_func(_fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
>> fs/smb/client/inode.c:2782:37: error: no member named 'counter' in 'struct refcount_struct'
2782 | full_path, inode, inode->i_count.counter,
| ~~~~~~~~~~~~~~ ^
fs/smb/client/cifs_debug.h:77:36: note: expanded from macro 'cifs_dbg'
77 | cifs_dbg_func(once, type, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
fs/smb/client/cifs_debug.h:70:32: note: expanded from macro 'cifs_dbg_func'
70 | pr_debug_ ## ratefunc(fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/printk.h:693:38: note: expanded from macro 'pr_debug_once'
693 | no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/printk.h:135:18: note: expanded from macro 'no_printk'
135 | _printk(fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
>> fs/smb/client/inode.c:2782:37: error: no member named 'counter' in 'struct refcount_struct'
2782 | full_path, inode, inode->i_count.counter,
| ~~~~~~~~~~~~~~ ^
fs/smb/client/cifs_debug.h:79:43: note: expanded from macro 'cifs_dbg'
79 | cifs_dbg_func(ratelimited, type, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
fs/smb/client/cifs_debug.h:66:23: note: expanded from macro 'cifs_dbg_func'
66 | __FILE__, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/printk.h:758:38: note: expanded from macro 'pr_debug_ratelimited'
758 | no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/printk.h:135:18: note: expanded from macro 'no_printk'
135 | _printk(fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
>> fs/smb/client/inode.c:2782:37: error: no member named 'counter' in 'struct refcount_struct'
2782 | full_path, inode, inode->i_count.counter,
| ~~~~~~~~~~~~~~ ^
fs/smb/client/cifs_debug.h:79:43: note: expanded from macro 'cifs_dbg'
79 | cifs_dbg_func(ratelimited, type, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
fs/smb/client/cifs_debug.h:68:38: note: expanded from macro 'cifs_dbg_func'
68 | pr_err_ ## ratefunc("VFS: " fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/printk.h:722:45: note: expanded from macro 'pr_err_ratelimited'
722 | printk_ratelimited(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/printk.h:708:17: note: expanded from macro 'printk_ratelimited'
708 | printk(fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/printk.h:514:60: note: expanded from macro 'printk'
514 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/printk.h:486:19: note: expanded from macro 'printk_index_wrap'
486 | _p_func(_fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
>> fs/smb/client/inode.c:2782:37: error: no member named 'counter' in 'struct refcount_struct'
2782 | full_path, inode, inode->i_count.counter,
| ~~~~~~~~~~~~~~ ^
fs/smb/client/cifs_debug.h:79:43: note: expanded from macro 'cifs_dbg'
79 | cifs_dbg_func(ratelimited, type, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
fs/smb/client/cifs_debug.h:70:32: note: expanded from macro 'cifs_dbg_func'
70 | pr_debug_ ## ratefunc(fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/printk.h:758:38: note: expanded from macro 'pr_debug_ratelimited'
758 | no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/printk.h:135:18: note: expanded from macro 'no_printk'
135 | _printk(fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
6 errors generated.
vim +2782 fs/smb/client/inode.c
abab095d1fd259 fs/cifs/inode.c Jeff Layton 2010-02-12 2755
6feb9891da4f8b fs/cifs/inode.c Pavel Shilovsky 2011-04-07 2756 int cifs_revalidate_dentry_attr(struct dentry *dentry)
df2cf170c823ba fs/cifs/inode.c Jeff Layton 2010-02-12 2757 {
6d5786a34d98bf fs/cifs/inode.c Pavel Shilovsky 2012-06-20 2758 unsigned int xid;
df2cf170c823ba fs/cifs/inode.c Jeff Layton 2010-02-12 2759 int rc = 0;
2b0143b5c986be fs/cifs/inode.c David Howells 2015-03-17 2760 struct inode *inode = d_inode(dentry);
df2cf170c823ba fs/cifs/inode.c Jeff Layton 2010-02-12 2761 struct super_block *sb = dentry->d_sb;
f6a9bc336b600e fs/cifs/inode.c Al Viro 2021-03-05 2762 const char *full_path;
f6a9bc336b600e fs/cifs/inode.c Al Viro 2021-03-05 2763 void *page;
fc513fac56e1b6 fs/cifs/inode.c Ronnie Sahlberg 2020-02-19 2764 int count = 0;
df2cf170c823ba fs/cifs/inode.c Jeff Layton 2010-02-12 2765
df2cf170c823ba fs/cifs/inode.c Jeff Layton 2010-02-12 2766 if (inode == NULL)
df2cf170c823ba fs/cifs/inode.c Jeff Layton 2010-02-12 2767 return -ENOENT;
^1da177e4c3f41 fs/cifs/inode.c Linus Torvalds 2005-04-16 2768
ed8561fa1d12b4 fs/cifs/inode.c Ronnie Sahlberg 2021-03-09 2769 if (!cifs_dentry_needs_reval(dentry))
6feb9891da4f8b fs/cifs/inode.c Pavel Shilovsky 2011-04-07 2770 return rc;
6feb9891da4f8b fs/cifs/inode.c Pavel Shilovsky 2011-04-07 2771
6d5786a34d98bf fs/cifs/inode.c Pavel Shilovsky 2012-06-20 2772 xid = get_xid();
^1da177e4c3f41 fs/cifs/inode.c Linus Torvalds 2005-04-16 2773
f6a9bc336b600e fs/cifs/inode.c Al Viro 2021-03-05 2774 page = alloc_dentry_path();
f6a9bc336b600e fs/cifs/inode.c Al Viro 2021-03-05 2775 full_path = build_path_from_dentry(dentry, page);
f6a9bc336b600e fs/cifs/inode.c Al Viro 2021-03-05 2776 if (IS_ERR(full_path)) {
f6a9bc336b600e fs/cifs/inode.c Al Viro 2021-03-05 2777 rc = PTR_ERR(full_path);
6feb9891da4f8b fs/cifs/inode.c Pavel Shilovsky 2011-04-07 2778 goto out;
^1da177e4c3f41 fs/cifs/inode.c Linus Torvalds 2005-04-16 2779 }
^1da177e4c3f41 fs/cifs/inode.c Linus Torvalds 2005-04-16 2780
f96637be081141 fs/cifs/inode.c Joe Perches 2013-05-04 2781 cifs_dbg(FYI, "Update attributes: %s inode 0x%p count %d dentry: 0x%p d_time %ld jiffies %ld\n",
f96637be081141 fs/cifs/inode.c Joe Perches 2013-05-04 @2782 full_path, inode, inode->i_count.counter,
a00be0e31f8df4 fs/cifs/inode.c Miklos Szeredi 2016-09-16 2783 dentry, cifs_get_time(dentry), jiffies);
^1da177e4c3f41 fs/cifs/inode.c Linus Torvalds 2005-04-16 2784
fc513fac56e1b6 fs/cifs/inode.c Ronnie Sahlberg 2020-02-19 2785 again:
102466f303ffcd fs/smb/client/inode.c Paulo Alcantara 2023-11-25 2786 if (cifs_sb_master_tcon(CIFS_SB(sb))->posix_extensions) {
102466f303ffcd fs/smb/client/inode.c Paulo Alcantara 2023-11-25 2787 rc = smb311_posix_get_inode_info(&inode, full_path,
102466f303ffcd fs/smb/client/inode.c Paulo Alcantara 2023-11-25 2788 NULL, sb, xid);
102466f303ffcd fs/smb/client/inode.c Paulo Alcantara 2023-11-25 2789 } else if (cifs_sb_master_tcon(CIFS_SB(sb))->unix_ext) {
df2cf170c823ba fs/cifs/inode.c Jeff Layton 2010-02-12 2790 rc = cifs_get_inode_info_unix(&inode, full_path, sb, xid);
102466f303ffcd fs/smb/client/inode.c Paulo Alcantara 2023-11-25 2791 } else {
df2cf170c823ba fs/cifs/inode.c Jeff Layton 2010-02-12 2792 rc = cifs_get_inode_info(&inode, full_path, NULL, sb,
df2cf170c823ba fs/cifs/inode.c Jeff Layton 2010-02-12 2793 xid, NULL);
102466f303ffcd fs/smb/client/inode.c Paulo Alcantara 2023-11-25 2794 }
fc513fac56e1b6 fs/cifs/inode.c Ronnie Sahlberg 2020-02-19 2795 if (rc == -EAGAIN && count++ < 10)
fc513fac56e1b6 fs/cifs/inode.c Ronnie Sahlberg 2020-02-19 2796 goto again;
6feb9891da4f8b fs/cifs/inode.c Pavel Shilovsky 2011-04-07 2797 out:
f6a9bc336b600e fs/cifs/inode.c Al Viro 2021-03-05 2798 free_dentry_path(page);
6d5786a34d98bf fs/cifs/inode.c Pavel Shilovsky 2012-06-20 2799 free_xid(xid);
fc513fac56e1b6 fs/cifs/inode.c Ronnie Sahlberg 2020-02-19 2800
^1da177e4c3f41 fs/cifs/inode.c Linus Torvalds 2005-04-16 2801 return rc;
^1da177e4c3f41 fs/cifs/inode.c Linus Torvalds 2005-04-16 2802 }
^1da177e4c3f41 fs/cifs/inode.c Linus Torvalds 2005-04-16 2803
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists