linux-ext4 - Re: [PATCH] jbd2: Increase IO priority of checkpoint.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2793c29e-4cdf-42a2-b8ce-55d362b560c3@huaweicloud.com>
Date: Tue, 26 Aug 2025 10:18:42 +0800
From: Zhang Yi <yi.zhang@...weicloud.com>
To: Julian Sun <sunjunchao@...edance.com>, linux-ext4@...r.kernel.org
Cc: tytso@....edu, jack@...e.com
Subject: Re: [PATCH] jbd2: Increase IO priority of checkpoint.

On 8/25/2025 8:53 PM, Julian Sun wrote:
> In commit 6a3afb6ac6df ("jbd2: increase the journal IO's priority"),
> the priority of IOs initiated by jbd2 has been raised, exempting them
> from WBT throttling.
> Checkpoint is also a crucial operation of jbd2. While no serious issues
> have been observed so far, it should still be reasonable to exempt
> checkpoint from WBT throttling.
> 
> Signed-off-by: Julian Sun <sunjunchao@...edance.com>

Looks reasonable to me. Thanks for the patch!

Reviewed-by: Zhang Yi <yi.zhang@...wei.com>

> ---
>  fs/jbd2/checkpoint.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/jbd2/checkpoint.c b/fs/jbd2/checkpoint.c
> index 38861ca04899..2d0719bf6d87 100644
> --- a/fs/jbd2/checkpoint.c
> +++ b/fs/jbd2/checkpoint.c
> @@ -131,7 +131,7 @@ __flush_batch(journal_t *journal, int *batch_count)
>  
>  	blk_start_plug(&plug);
>  	for (i = 0; i < *batch_count; i++)
> -		write_dirty_buffer(journal->j_chkpt_bhs[i], REQ_SYNC);
> +		write_dirty_buffer(journal->j_chkpt_bhs[i], JBD2_JOURNAL_REQ_FLAGS);
>  	blk_finish_plug(&plug);
>  
>  	for (i = 0; i < *batch_count; i++) {