linux-ext4 - Re: [PATCH RFC 2/3] mke2fs.c: fail on multiple '-E' options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <17EED9B4-41D4-4D1C-9838-1ECF5B39C00D@dilger.ca>
Date: Tue, 9 Sep 2025 18:32:08 -0600
From: Andreas Dilger <adilger@...ger.ca>
To: Ralph Siemsen <ralph.siemsen@...aro.org>
Cc: linux-ext4@...r.kernel.org, Ralph Siemsen <ralph.siemsen@...aro.org>
Subject: Re: [PATCH RFC 2/3] mke2fs.c: fail on multiple '-E' options

Ralph,
I think it would be much better to allow and merge multiple "-E" options.

Cheers, Andreas

> On Sep 9, 2025, at 09:43, Ralph Siemsen <ralph.siemsen@...aro.org> wrote:
> 
> Make it an error to pass multiple -E options. As per the man page,
> multiple extended options must be specified as a comma-separated list,
> instead of multiple -E options.
> 
> This helps avoid surprises, as the existing behaviour is to process
> only the last -E option, and to silently ignore any earlier ones.
> 
> Signed-off-by: Ralph Siemsen <ralph.siemsen@...aro.org>
> ---
> misc/mke2fs.c | 6 ++++++
> 1 file changed, 6 insertions(+)
> 
> diff --git a/misc/mke2fs.c b/misc/mke2fs.c
> index 3a8ff5b1..59c7be17 100644
> --- a/misc/mke2fs.c
> +++ b/misc/mke2fs.c
> @@ -1796,6 +1796,12 @@ profile_error:
>                _("'-R' is deprecated, use '-E' instead"));
>            /* fallthrough */
>        case 'E':
> +            if (extended_opts) {
> +                com_err(program_name, 0, "%s",
> +                    _("Multiple '-E' options are not supported, "
> +                      "use one comma-separated value instead"));
> +                exit(1);
> +            }
>            extended_opts = optarg;
>            break;
>        case 'e':
> 
> --
> 2.45.2.121.gc2b3f2b3cd
> 
>