linux-ext4 - Re: [PATCH RESEND 13/62] ext2: remove ext2_image

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5xr5efvf4dhy43fchbvfsxspzgde5bxezhszdgqcya4eqrocgy@lqqkaq5wok6a>
Date: Mon, 15 Sep 2025 11:19:38 +0200
From: Jan Kara <jack@...e.cz>
To: Askar Safin <safinaskar@...il.com>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Linus Torvalds <torvalds@...ux-foundation.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Christian Brauner <brauner@...nel.org>, Al Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>, 
	Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>, 
	Andy Shevchenko <andy.shevchenko@...il.com>, Aleksa Sarai <cyphar@...har.com>, 
	Thomas Weißschuh <thomas.weissschuh@...utronix.de>, Julian Stecklina <julian.stecklina@...erus-technology.de>, 
	Gao Xiang <hsiangkao@...ux.alibaba.com>, Art Nikpal <email2tema@...il.com>, 
	Andrew Morton <akpm@...ux-foundation.org>, Eric Curtin <ecurtin@...hat.com>, 
	Alexander Graf <graf@...zon.com>, Rob Landley <rob@...dley.net>, 
	Lennart Poettering <mzxreary@...inter.de>, linux-arch@...r.kernel.org, linux-alpha@...r.kernel.org, 
	linux-snps-arc@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, linux-csky@...r.kernel.org, 
	linux-hexagon@...r.kernel.org, loongarch@...ts.linux.dev, linux-m68k@...ts.linux-m68k.org, 
	linux-mips@...r.kernel.org, linux-openrisc@...r.kernel.org, linux-parisc@...r.kernel.org, 
	linuxppc-dev@...ts.ozlabs.org, linux-riscv@...ts.infradead.org, linux-s390@...r.kernel.org, 
	linux-sh@...r.kernel.org, sparclinux@...r.kernel.org, linux-um@...ts.infradead.org, 
	x86@...nel.org, Ingo Molnar <mingo@...hat.com>, linux-block@...r.kernel.org, 
	initramfs@...r.kernel.org, linux-api@...r.kernel.org, linux-doc@...r.kernel.org, 
	linux-efi@...r.kernel.org, linux-ext4@...r.kernel.org, "Theodore Y . Ts'o" <tytso@....edu>, 
	linux-acpi@...r.kernel.org, Michal Simek <monstr@...str.eu>, devicetree@...r.kernel.org, 
	Luis Chamberlain <mcgrof@...nel.org>, Kees Cook <kees@...nel.org>, 
	Thorsten Blum <thorsten.blum@...ux.dev>, Heiko Carstens <hca@...ux.ibm.com>, patches@...ts.linux.dev
Subject: Re: [PATCH RESEND 13/62] ext2: remove ext2_image_size and associated
 code

On Sat 13-09-25 00:37:52, Askar Safin wrote:
> It is not used anymore
> 
> Signed-off-by: Askar Safin <safinaskar@...il.com>

Looks good.

Acked-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/ext2/ext2.h          |  9 ---------
>  include/linux/ext2_fs.h | 13 -------------
>  2 files changed, 22 deletions(-)
> 
> diff --git a/fs/ext2/ext2.h b/fs/ext2/ext2.h
> index cf97b76e9fd3..d623a14040d9 100644
> --- a/fs/ext2/ext2.h
> +++ b/fs/ext2/ext2.h
> @@ -608,15 +608,6 @@ struct ext2_dir_entry_2 {
>  					 ~EXT2_DIR_ROUND)
>  #define EXT2_MAX_REC_LEN		((1<<16)-1)
>  
> -static inline void verify_offsets(void)
> -{
> -#define A(x,y) BUILD_BUG_ON(x != offsetof(struct ext2_super_block, y));
> -	A(EXT2_SB_MAGIC_OFFSET, s_magic);
> -	A(EXT2_SB_BLOCKS_OFFSET, s_blocks_count);
> -	A(EXT2_SB_BSIZE_OFFSET, s_log_block_size);
> -#undef A
> -}
> -
>  /*
>   * ext2 mount options
>   */
> diff --git a/include/linux/ext2_fs.h b/include/linux/ext2_fs.h
> index 1fef88569037..e5ebe6cdf06c 100644
> --- a/include/linux/ext2_fs.h
> +++ b/include/linux/ext2_fs.h
> @@ -27,17 +27,4 @@
>   */
>  #define EXT2_LINK_MAX		32000
>  
> -#define EXT2_SB_MAGIC_OFFSET	0x38
> -#define EXT2_SB_BLOCKS_OFFSET	0x04
> -#define EXT2_SB_BSIZE_OFFSET	0x18
> -
> -static inline u64 ext2_image_size(void *ext2_sb)
> -{
> -	__u8 *p = ext2_sb;
> -	if (*(__le16 *)(p + EXT2_SB_MAGIC_OFFSET) != cpu_to_le16(EXT2_SUPER_MAGIC))
> -		return 0;
> -	return (u64)le32_to_cpup((__le32 *)(p + EXT2_SB_BLOCKS_OFFSET)) <<
> -		le32_to_cpup((__le32 *)(p + EXT2_SB_BSIZE_OFFSET));
> -}
> -
>  #endif	/* _LINUX_EXT2_FS_H */
> -- 
> 2.47.2
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR