lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <728E8839-CC3D-4316-9FD6-7819CCE0DC07@dilger.ca>
Date: Sat, 20 Sep 2025 16:59:10 -0600
From: Andreas Dilger <adilger@...ger.ca>
To: Ralph Siemsen <ralph.siemsen@...aro.org>
Cc: linux-ext4@...r.kernel.org
Subject: Re: [PATCH v2 4/4] mke2fs: fix missing .TP in man page

On Sep 10, 2025, at 7:51 AM, Ralph Siemsen <ralph.siemsen@...aro.org> wrote:
> 
> Signed-off-by: Ralph Siemsen <ralph.siemsen@...aro.org>

Looks fine.  I found a related formatting issue with a duplicate .TP marker
in another part of mke2fs.8.in, and have submitted a separate patch for that.

It looks like this patch could have:
Fixes: 3fffe9dd6be5 ("tune2fs: replace the -r option with -E revision=<fs-rev>")

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

> ---
> misc/mke2fs.8.in | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/misc/mke2fs.8.in b/misc/mke2fs.8.in
> index ffe02eb0..94d82082 100644
> --- a/misc/mke2fs.8.in
> +++ b/misc/mke2fs.8.in
> @@ -739,6 +739,7 @@ the manual page
> Quiet execution.  Useful if
> .B mke2fs
> is run in a script.
> +.TP
> .B \-S
> Write superblock and group descriptors only.  This is an extreme
> measure to be taken only in the very unlikely case that all of
> 
> --
> 2.45.2.121.gc2b3f2b3cd
> 
> 


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ