linux-ext4 - [ext4] ext4_ext_correct_indexes() TODO about “border is smaller”

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAHxJ8O_WWRGmJp6t2_-BERc99RohpNmhcOtP=xMqJKakJouPFg@mail.gmail.com>
Date: Tue, 30 Sep 2025 16:22:32 +0300
From: Ahmet Eray Karadag <eraykrdg1@...il.com>
To: tytso@....edu, adilger.kernel@...ger.ca
Cc: linux-ext4@...r.kernel.org
Subject: [ext4] ext4_ext_correct_indexes() TODO about “border is smaller” — still valid?

Hi folks,

In fs/ext4/extents.c, ext4_ext_correct_indexes() has:

    /* TODO: we need correction if border is smaller than current one */

Is this TODO outdated? My understanding is parent ei_block should be updated
whenever the leaf’s first extent border shrinks.

I implemented the TODO literally (only-lower) and kvm-xfstests smoke
started failing (generic/475, 476).

Would you please let me know if it's stale?

Thanks,
Ahmet Eray