linux-ext4 - Re: filemap_* writeback interface cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bf280a12-28b2-445a-8ed2-cc63d4c57a36@wdc.com>
Date: Mon, 13 Oct 2025 08:12:16 +0000
From: Johannes Thumshirn <Johannes.Thumshirn@....com>
To: hch <hch@....de>, "Matthew Wilcox (Oracle)" <willy@...radead.org>, Eric
 Van Hensbergen <ericvh@...nel.org>, Latchesar Ionkov <lucho@...kov.net>,
	Dominique Martinet <asmadeus@...ewreck.org>, Christian Schoenebeck
	<linux_oss@...debyte.com>, Chris Mason <clm@...com>, David Sterba
	<dsterba@...e.com>, Mark Fasheh <mark@...heh.com>, Joel Becker
	<jlbec@...lplan.org>, Joseph Qi <joseph.qi@...ux.alibaba.com>
CC: Alexander Viro <viro@...iv.linux.org.uk>, Christian Brauner
	<brauner@...nel.org>, Josef Bacik <josef@...icpanda.com>, Jan Kara
	<jack@...e.cz>, "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
	"v9fs@...ts.linux.dev" <v9fs@...ts.linux.dev>, "linux-btrfs@...r.kernel.org"
	<linux-btrfs@...r.kernel.org>, "linux-ext4@...r.kernel.org"
	<linux-ext4@...r.kernel.org>, "linux-fsdevel@...r.kernel.org"
	<linux-fsdevel@...r.kernel.org>, "jfs-discussion@...ts.sourceforge.net"
	<jfs-discussion@...ts.sourceforge.net>, "ocfs2-devel@...ts.linux.dev"
	<ocfs2-devel@...ts.linux.dev>, "linux-xfs@...r.kernel.org"
	<linux-xfs@...r.kernel.org>, "linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: filemap_* writeback interface cleanups

On 10/13/25 4:58 AM, Christoph Hellwig wrote:
> Hi all,
>
> while looking at the filemap writeback code, I think adding
> filemap_fdatawrite_wbc ended up being a mistake, as all but the original
> btrfs caller should be using better high level interfaces instead.  This
> series removes all these, switches btrfs to a more specific interfaces
> and also cleans up another too low-level interface.  With this the
> writeback_control that is passed to the writeback code is only
> initialized in three places, although there are a lot more places in
> file system code that never reach the common writeback code.
>
> Diffstat:
>   block/bdev.c            |    2
>   fs/9p/vfs_file.c        |   17 +------
>   fs/btrfs/defrag.c       |    4 -
>   fs/btrfs/extent_io.c    |    3 -
>   fs/btrfs/file.c         |    2
>   fs/btrfs/inode.c        |   52 +++++++---------------
>   fs/btrfs/reflink.c      |    2
>   fs/btrfs/super.c        |    2
>   fs/ext4/inline.c        |    2
>   fs/ext4/inode.c         |    6 +-
>   fs/fat/inode.c          |    2
>   fs/fs-writeback.c       |    6 +-
>   fs/jfs/jfs_logmgr.c     |    2
>   fs/ocfs2/journal.c      |   11 ----
>   fs/sync.c               |   11 ++--
>   fs/xfs/xfs_file.c       |    2
>   include/linux/pagemap.h |    8 +--
>   mm/fadvise.c            |    3 -
>   mm/filemap.c            |  109 +++++++++++++++++++-----------------------------
>   mm/khugepaged.c         |    2
>   20 files changed, 95 insertions(+), 153 deletions(-)
>
>
Looks good,

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@....com>