[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20251014173706.GB13776@suse.cz>
Date: Tue, 14 Oct 2025 19:37:06 +0200
From: David Sterba <dsterba@...e.cz>
To: Johannes Thumshirn <Johannes.Thumshirn@....com>
Cc: hch <hch@....de>, David Sterba <dsterba@...e.com>,
"Matthew Wilcox (Oracle)" <willy@...radead.org>,
Eric Van Hensbergen <ericvh@...nel.org>,
Latchesar Ionkov <lucho@...kov.net>,
Dominique Martinet <asmadeus@...ewreck.org>,
Christian Schoenebeck <linux_oss@...debyte.com>,
Chris Mason <clm@...com>, Mark Fasheh <mark@...heh.com>,
Joel Becker <jlbec@...lplan.org>,
Joseph Qi <joseph.qi@...ux.alibaba.com>,
Alexander Viro <viro@...iv.linux.org.uk>,
Christian Brauner <brauner@...nel.org>,
Josef Bacik <josef@...icpanda.com>, Jan Kara <jack@...e.cz>,
"linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
"v9fs@...ts.linux.dev" <v9fs@...ts.linux.dev>,
"linux-btrfs@...r.kernel.org" <linux-btrfs@...r.kernel.org>,
"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
"jfs-discussion@...ts.sourceforge.net" <jfs-discussion@...ts.sourceforge.net>,
"ocfs2-devel@...ts.linux.dev" <ocfs2-devel@...ts.linux.dev>,
"linux-xfs@...r.kernel.org" <linux-xfs@...r.kernel.org>,
"linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: [PATCH 04/10] btrfs: use the local tmp_inode variable in
start_delalloc_inodes
On Tue, Oct 14, 2025 at 07:02:11AM +0000, Johannes Thumshirn wrote:
> On 10/14/25 6:44 AM, hch wrote:
> > On Mon, Oct 13, 2025 at 08:11:35AM +0000, Johannes Thumshirn wrote:
> >> If you have to repost this for some reason, can you rename tmp_inode to
> >> vfs_inode or sth like that?
> >>
> >> The name is really confusing and the commit introducing it doesn't
> >> describe it really either.
> > It is. vfs_inode is kinda weird, too. The problem is that inode
> > is used for the btrfs_inode. But if there's consensus on a name
> > I'll happily change it.
> >
> I unfortunately don't have one :( David?
For this series it's fine to use tmp_inode as it's already there, we can
rename it later.
Powered by blists - more mailing lists