[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aPKroGbrXvuoBZUl@cern.ch>
Date: Fri, 17 Oct 2025 15:48:32 -0500
From: Dave Dykstra <dwd@...n.ch>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: linux-ext4@...r.kernel.org,
Dave Dykstra <2129743+DrDaveD@...rs.noreply.github.com>
Subject: Re: [PATCH] fuse2fs: open read-only when ro option and image
non-writable
On Fri, Oct 17, 2025 at 03:14:50PM -0500, Dave Dykstra wrote:
> On Fri, Oct 17, 2025 at 12:24:56PM -0700, Darrick J. Wong wrote:
...
> > > + ret = 4;
> >
> > Why 4? Is this an internal mount bug?
>
> I was just guessing; I didn't know what the bits meant. Where are they
> documented? All I knew was that it needed to not include the "& 1" bit
> which was included with "ret = 3" because that printed an erroneous
> error just after the "out" label.
Oh, it's supposed to follow the return codes from mount(8). I think
ret = 2 is most appropriate then.
Dave
Powered by blists - more mailing lists