linux-ext4 - Re: filemap_* writeback interface cleanups v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251029-fahrdienst-klaglos-834e266b8e42@brauner>
Date: Wed, 29 Oct 2025 15:53:19 +0100
From: Christian Brauner <brauner@...nel.org>
To: Christoph Hellwig <hch@....de>
Cc: Christian Brauner <brauner@...nel.org>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Josef Bacik <josef@...icpanda.com>,
	Jan Kara <jack@...e.cz>,
	linux-block@...r.kernel.org,
	v9fs@...ts.linux.dev,
	linux-btrfs@...r.kernel.org,
	linux-ext4@...r.kernel.org,
	linux-fsdevel@...r.kernel.org,
	jfs-discussion@...ts.sourceforge.net,
	ocfs2-devel@...ts.linux.dev,
	linux-xfs@...r.kernel.org,
	linux-mm@...ck.org,
	"Matthew Wilcox (Oracle)" <willy@...radead.org>,
	Eric Van Hensbergen <ericvh@...nel.org>,
	Latchesar Ionkov <lucho@...kov.net>,
	Dominique Martinet <asmadeus@...ewreck.org>,
	Christian Schoenebeck <linux_oss@...debyte.com>,
	Chris Mason <clm@...com>,
	David Sterba <dsterba@...e.com>,
	Mark Fasheh <mark@...heh.com>,
	Joel Becker <jlbec@...lplan.org>,
	Joseph Qi <joseph.qi@...ux.alibaba.com>
Subject: Re: filemap_* writeback interface cleanups v2

On Fri, 24 Oct 2025 10:04:11 +0200, Christoph Hellwig wrote:
> while looking at the filemap writeback code, I think adding
> filemap_fdatawrite_wbc ended up being a mistake, as all but the original
> btrfs caller should be using better high level interfaces instead.  This
> series removes all these, switches btrfs to a more specific interfaces
> and also cleans up another too low-level interface.  With this the
> writeback_control that is passed to the writeback code is only
> initialized in three places, although there are a lot more places in
> file system code that never reach the common writeback code.
> 
> [...]

Applied to the vfs-6.19.writeback branch of the vfs/vfs.git tree.
Patches in the vfs-6.19.writeback branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.19.writeback

[01/10] mm: don't opencode filemap_fdatawrite_range in filemap_invalidate_inode
        https://git.kernel.org/vfs/vfs/c/a21134b5d6cb
[02/10] 9p: don't opencode filemap_fdatawrite_range in v9fs_mmap_vm_close
        https://git.kernel.org/vfs/vfs/c/3c2e5cee5eb3
[03/10] ocfs2: don't opencode filemap_fdatawrite_range in ocfs2_journal_submit_inode_data_buffers
        https://git.kernel.org/vfs/vfs/c/890f141da068
[04/10] btrfs: use the local tmp_inode variable in start_delalloc_inodes
        https://git.kernel.org/vfs/vfs/c/41e52c644753
[05/10] btrfs: push struct writeback_control into start_delalloc_inodes
        https://git.kernel.org/vfs/vfs/c/c9501112e3cb
[06/10] mm,btrfs: add a filemap_flush_nr helper
        https://git.kernel.org/vfs/vfs/c/7fabcb7fbabb
[07/10] mm: remove __filemap_fdatawrite
        https://git.kernel.org/vfs/vfs/c/735965144806
[08/10] mm: remove filemap_fdatawrite_wbc
        https://git.kernel.org/vfs/vfs/c/1bcb413d0cd8
[09/10] mm: remove __filemap_fdatawrite_range
        https://git.kernel.org/vfs/vfs/c/45cbce5b8877
[10/10] mm: rename filemap_fdatawrite_range_kick to filemap_flush_range
        https://git.kernel.org/vfs/vfs/c/c28d67b33cbf