linux-ext4 - Re: [PATCH 27/33] generic/050: skip test because fuse2fs doesn't have stable output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOQ4uxgoZ_wrExQLsO2CfF8AFQ+n2T1WBHenwuteMUdnoO+Piw@mail.gmail.com>
Date: Thu, 30 Oct 2025 11:05:52 +0100
From: Amir Goldstein <amir73il@...il.com>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: zlang@...hat.com, neal@...pa.dev, fstests@...r.kernel.org, 
	linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, 
	joannelkoong@...il.com, bernd@...ernd.com
Subject: Re: [PATCH 27/33] generic/050: skip test because fuse2fs doesn't have
 stable output

On Wed, Oct 29, 2025 at 2:30 AM Darrick J. Wong <djwong@...nel.org> wrote:
>
> From: Darrick J. Wong <djwong@...nel.org>
>
> fuse2fs doesn't have a stable output, so skip this test for now.
>
> --- a/tests/generic/050.out      2025-07-15 14:45:14.951719283 -0700
> +++ b/tests/generic/050.out.bad        2025-07-16 14:06:28.283170486 -0700
> @@ -1,7 +1,7 @@
>  QA output created by 050
> +FUSE2FS (sdd): Warning: Mounting unchecked fs, running e2fsck is recommended.

oopsy here

>  setting device read-only
>  mounting read-only block device:
> -mount: device write-protected, mounting read-only
>  touching file on read-only filesystem (should fail)
>  touch: cannot touch 'SCRATCH_MNT/foo': Read-only file system
>  unmounting read-only filesystem
> @@ -12,10 +12,10 @@
>  unmounting shutdown filesystem:
>  setting device read-only
>  mounting filesystem that needs recovery on a read-only device:
> -mount: device write-protected, mounting read-only
>  unmounting read-only filesystem
>  mounting filesystem with -o norecovery on a read-only device:
> -mount: device write-protected, mounting read-only
> +FUSE2FS (sdd): read-only device, trying to mount norecovery
> +FUSE2FS (sdd): Warning: Mounting unchecked fs, running e2fsck is recommended

and here

>  unmounting read-only filesystem
>  setting device read-write
>  mounting filesystem that needs recovery with -o ro:
>
> Signed-off-by: "Darrick J. Wong" <djwong@...nel.org>
> ---
>  tests/generic/050 |    4 ++++
>  1 file changed, 4 insertions(+)
>
>
> diff --git a/tests/generic/050 b/tests/generic/050
> index 3bc371756fd221..13fbdbbfeed2b6 100755
> --- a/tests/generic/050
> +++ b/tests/generic/050
> @@ -47,6 +47,10 @@ elif [ "$FSTYP" = "btrfs" ]; then
>         # it can be treated as "nojournal".
>         features="nojournal"
>  fi
> +if [[ "$FSTYP" =~ fuse.ext[234] ]]; then
> +       # fuse2fs doesn't have stable output, skip this test...
> +       _notrun "fuse doesn't have stable output"
> +fi

Is this statement correct in general for fuse or specifically for fuse2fs?

If general, than I would rather foresee fuse.xfs and make it:

if [[ ! "$FSTYP" =~ fuse.* ]];

Thanks,
Amir.