linux-ext4 - Re: [PATCH RFC 5/8] ext4: use super write guard in write_mmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <lc6hg6trbptznsbxmx3b4ayzz3v5wfs6dqntjz54ujap6j6crk@q7iq4gojfnnx>
Date: Tue, 4 Nov 2025 13:32:22 +0100
From: Jan Kara <jack@...e.cz>
To: Christian Brauner <brauner@...nel.org>
Cc: linux-fsdevel@...r.kernel.org, 
	Alexander Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>, linux-btrfs@...r.kernel.org, 
	linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org
Subject: Re: [PATCH RFC 5/8] ext4: use super write guard in write_mmp_block()

On Tue 04-11-25 13:12:34, Christian Brauner wrote:
> Signed-off-by: Christian Brauner <brauner@...nel.org>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/ext4/mmp.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c
> index ab1ff51302fb..6f57c181ff77 100644
> --- a/fs/ext4/mmp.c
> +++ b/fs/ext4/mmp.c
> @@ -57,16 +57,12 @@ static int write_mmp_block_thawed(struct super_block *sb,
>  
>  static int write_mmp_block(struct super_block *sb, struct buffer_head *bh)
>  {
> -	int err;
> -
>  	/*
>  	 * We protect against freezing so that we don't create dirty buffers
>  	 * on frozen filesystem.
>  	 */
> -	sb_start_write(sb);
> -	err = write_mmp_block_thawed(sb, bh);
> -	sb_end_write(sb);
> -	return err;
> +	scoped_guard(super_write, sb)
> +		return write_mmp_block_thawed(sb, bh);
>  }
>  
>  /*
> 
> -- 
> 2.47.3
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR