linux-ext4 - Re: [PATCH v2 2/4] ext4: rename EXT4_GET_BLOCKS_PRE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yk27mj4w5t4jpbrkd7a5exkuvzghj3ou2yaa45dninci765xlu@ndftxnnxhtao>
Date: Tue, 4 Nov 2025 15:32:35 +0100
From: Jan Kara <jack@...e.cz>
To: Yang Erkun <yangerkun@...wei.com>
Cc: linux-ext4@...r.kernel.org, tytso@....edu, adilger.kernel@...ger.ca, 
	jack@...e.cz, yi.zhang@...wei.com, libaokun1@...wei.com, 
	yangerkun@...weicloud.com
Subject: Re: [PATCH v2 2/4] ext4: rename EXT4_GET_BLOCKS_PRE_IO

On Tue 04-11-25 21:17:48, Yang Erkun wrote:
> This flag has been generalized to split an unwritten extent when we do
> dio or dioread_nolock writeback, or to avoid merge new extents which was
> created by extents split. Update some related comments too.
> 
> Signed-off-by: Yang Erkun <yangerkun@...wei.com>

Just a few spelling corrections. Otherwise I like the patch. Feel free to
add:

Reviewed-by: Jan Kara <jack@...e.cz>

> +	/*
> +	 * Caller is from the dio or dioread_nolock buffer writeback,
						    ^^^ buffered IO

> +	 * request to creation of an unwritten extent if not exist or split
			^^ create an unwritten extent if it does not exist

> +	 * the found unwritten extent. Also do not merge the new create
							     ^^^ newly created

> +	 * unwritten extent, io end will convert unwritten to written, and
> +	 * try to merge the written extent.
> +	 */

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR