linux-ext4 - Re: [PATCH RFC 3/8] btrfs: use super write guard btrfs_run_defrag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251106081945.GU13846@twin.jikos.cz>
Date: Thu, 6 Nov 2025 09:19:45 +0100
From: David Sterba <dsterba@...e.cz>
To: Christian Brauner <brauner@...nel.org>
Cc: linux-fsdevel@...r.kernel.org, Alexander Viro <viro@...iv.linux.org.uk>,
	Jan Kara <jack@...e.cz>, linux-btrfs@...r.kernel.org,
	linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org
Subject: Re: [PATCH RFC 3/8] btrfs: use super write guard
 btrfs_run_defrag_inode()

On Tue, Nov 04, 2025 at 01:12:32PM +0100, Christian Brauner wrote:
> Signed-off-by: Christian Brauner <brauner@...nel.org>
> ---
>  fs/btrfs/defrag.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/btrfs/defrag.c b/fs/btrfs/defrag.c
> index 7b277934f66f..35fb8ee164dc 100644
> --- a/fs/btrfs/defrag.c
> +++ b/fs/btrfs/defrag.c
> @@ -254,10 +254,9 @@ static int btrfs_run_defrag_inode(struct btrfs_fs_info *fs_info,
>  	range.extent_thresh = defrag->extent_thresh;
>  	file_ra_state_init(ra, inode->vfs_inode.i_mapping);
>  
> -	sb_start_write(fs_info->sb);
> -	ret = btrfs_defrag_file(inode, ra, &range, defrag->transid,
> -				BTRFS_DEFRAG_BATCH);
> -	sb_end_write(fs_info->sb);
> +	scoped_guard(super_write, fs_info->sb)
> +		ret = btrfs_defrag_file(inode, ra, &range,
> +					defrag->transid, BTRFS_DEFRAG_BATCH);

Please use explicit { } around scoped_guard() in btrfs code. It makes
the scope more obvious.