linux-ext4 - [PATCH 1/7] common: leave any breadcrumbs when _link_out_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <176279909022.605950.903689908646225008.stgit@frogsfrogsfrogs>
Date: Mon, 10 Nov 2025 10:26:17 -0800
From: "Darrick J. Wong" <djwong@...nel.org>
To: djwong@...nel.org, zlang@...hat.com
Cc: fstests@...r.kernel.org, linux-ext4@...r.kernel.org
Subject: [PATCH 1/7] common: leave any breadcrumbs when _link_out_file_named
 can't find the output file

From: Darrick J. Wong <djwong@...nel.org>

_link_out_file_named is an obnoxiously complicated helper involving a
perl script embedded inside a bash subshell that does ... a lookup of
some sort involving comparing the comma-separated list in its second
argument against a comma-separated list in a config file that then maps
to an output file suffix.  I don't know what it really does.  The .cfg
file format is undocumented except for the perl script.

This is really irritating every time I have to touch any of these tests
with flexible golden outputs, and I frequently screw up the mapping.
The helper is not very helpful when you do this, because it doesn't even
try to tell you *which* suffix it found, let alone how it got there.

Fix this up so that the .full file gets some diagnostics, even if the
stdout text is "no qualified output".

Signed-off-by: "Darrick J. Wong" <djwong@...nel.org>
---
 common/rc |    1 +
 1 file changed, 1 insertion(+)

diff --git a/common/rc b/common/rc
index a10ac17746a3ca..cb91c00d24fb19 100644
--- a/common/rc
+++ b/common/rc
@@ -3825,6 +3825,7 @@ _link_out_file_named()
 		' <$seqfull.cfg)
 	rm -f $1 || _fail "_link_out_file_named: failed to remove existing output file"
 	ln -fs $(basename $1).$suffix $1 || _fail "$(basename $1).$suffix: could not setup output file"
+	test -r $1 || _fail "$(basename $1).$suffix: output file for feature set \"$2\" not found"
 }

 _link_out_file()