linux-ext4 - Re: [PATCH 04/33] common/rc: skip test if swapon doesn't work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251112200540.GD3131573@mit.edu>
Date: Wed, 12 Nov 2025 15:05:40 -0500
From: "Theodore Ts'o" <tytso@....edu>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: Baokun Li <libaokun1@...wei.com>, zlang@...hat.com, neal@...pa.dev,
        fstests@...r.kernel.org, linux-ext4@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, joannelkoong@...il.com,
        bernd@...ernd.com
Subject: Re: [PATCH 04/33] common/rc: skip test if swapon doesn't work

On Wed, Nov 12, 2025 at 10:26:17AM -0800, Darrick J. Wong wrote:
> 
> Well at that point we might as well collapse everything into:
> 
> 	if ! swapon "$SCRATCH_MNT/swap" >/dev/null 2>&1; then
> 		_scratch_unmount
> 		_notrun "swapfiles are not supported for $FSTYP"
> 	fi

Agreed.  I don't think the ext4 special case makes sense here.  If we
want to have a specific "swapfiles are working when we expect them
to", let's do that as a single file system specific test.  Let's keep
_require_scratch_swapfile simple.

						- Ted