linux-ext4 - Re: [PATCH 04/12] ext4/032: use _check_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251210232444.GL94594@frogsfrogsfrogs>
Date: Wed, 10 Dec 2025 15:24:44 -0800
From: "Darrick J. Wong" <djwong@...nel.org>
To: Christoph Hellwig <hch@....de>
Cc: Zorro Lang <zlang@...nel.org>, Anand Jain <anand.jain@...cle.com>,
	Filipe Manana <fdmanana@...e.com>, fstests@...r.kernel.org,
	linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org
Subject: Re: [PATCH 04/12] ext4/032: use _check_dev_fs

On Wed, Dec 10, 2025 at 06:46:50AM +0100, Christoph Hellwig wrote:
> _check_dev_fs is the new designated helper to check file systems on
> arbitrary devices, use that instead of _check_generic_filesystem, which
> is just an implementation detail.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>

Looks reasonable to me,
Reviewed-by: "Darrick J. Wong" <djwong@...nel.org>

--D

> ---
>  tests/ext4/032 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/ext4/032 b/tests/ext4/032
> index 690fcf066c11..043ae4f53505 100755
> --- a/tests/ext4/032
> +++ b/tests/ext4/032
> @@ -66,7 +66,7 @@ ext4_online_resize()
>  	$UMOUNT_PROG ${IMG_MNT}
>  
>  	echo "+++ check fs" | tee -a $seqres.full
> -	_check_generic_filesystem $LOOP_DEVICE >> $seqres.full 2>&1 || \
> +	_check_dev_fs $LOOP_DEVICE >> $seqres.full 2>&1 || \
>  		_fail "fsck should not fail"
>  	_destroy_loop_device $LOOP_DEVICE && LOOP_DEVICE=
>  }
> -- 
> 2.47.3
> 
>